From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790C93FC1 for ; Wed, 25 Aug 2021 03:54:17 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id 7so20130281pfl.10 for ; Tue, 24 Aug 2021 20:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CVEoBZ/UnTo6nLZUccYHUvCMvIcxl/WBSnIq60Ivb00=; b=heeEu0ku4/ofb/JqTrjFVArqpzXSELI9PpG8iyH2oUVcapzxZ4F6eUSll21FaFoEHG rEOcs1p1bjAZ6S0EXDsLYSwpCHJKPlc9FWoJjw6SwmZs/gZDa2QZFfDm6hoPj4zMG2KQ 63KYFn007p3fCw3teQ2BiiRzNgdDBrbMOK4YQklMkupPtNZ7Gew5Okrt0YKmu7yc0EN+ P31EcfDqEGGIWNLVq90dVWeRu59B+W0L962bFxO8PV0pRntWkNobSK0Gc2R9c/loIIk8 bRWQLUrdSeSWepgA1KbFuOHRm3qcScANquXK6KhPjSLwF0rL9T70YGWQUDaaDJtoO64Z m45A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CVEoBZ/UnTo6nLZUccYHUvCMvIcxl/WBSnIq60Ivb00=; b=r7oC+F7QTaib7l4l9X/fRF4EQGjVUSrRXYKoKdzA9ATPABtZENz0onO07lfk1cIltH VSubjQalW5QlwekgpKmsJrmK6z9quaRRxt8OF6JHudNwM0l+y18WGOTYyqBPcrBARiKC pejO1DMCOb2ficlbKI+Q9ppDx6/b/J29pUzM6TcCw5C78fFhgf4k9HBIrQuiGU3ye4XD rXTTDqS1XYJa8dz3ZiNDkGKAiq+T/jeaEx5kCxlpl+PNMmwXHooZigd1o/Vjzk46JomV IL8U0NXAJsxzfBqO+FOeAnsOIh0CPdlEwCvDAMDKPz0awM5Chkjqy1eY5lJpftxobr86 3zxA== X-Gm-Message-State: AOAM531PlXYLOy16/AOeQM+c1VnAJJDN2cOsaxlGucTdUqzzBi16H/5M 3wGOpVYRpZ703oiog/OcrZU= X-Google-Smtp-Source: ABdhPJyfIo5M/sa9StAar1/4CefQWSbehUpQcoL0gNc4p1Jr9nqXEIqqpaaMlJjYqnxXC/a2ilaFig== X-Received: by 2002:a63:535f:: with SMTP id t31mr4818786pgl.270.1629863656844; Tue, 24 Aug 2021 20:54:16 -0700 (PDT) Received: from user ([122.175.21.197]) by smtp.gmail.com with ESMTPSA id h9sm4138369pjg.9.2021.08.24.20.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 20:54:16 -0700 (PDT) Date: Wed, 25 Aug 2021 09:24:10 +0530 From: SAURAV GIREPUNJE To: Phillip Potter Cc: "Fabio M. De Francesco" , Larry Finger , Greg KH , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List , saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect Message-ID: References: <1821445.fzUCeO1EU3@localhost.localdomain> <18734228.Nv2I6EOGHm@localhost.localdomain> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 23 Aug 2021 00:58, Phillip Potter wrote: > On Sun, 22 Aug 2021 at 17:24, Fabio M. De Francesco > wrote: > > > > > > Dear Philip, > > > > I didn't mean to be harsh with you, I apologize if this is the message > > I conveyed. Really! > > Dear Fabio, > > No apology necessary :-) > > > > > > > Now it is clearer to me what acking means. I've given only a handful of > > acks because I thought I should also check if they applied and if they > > build. It takes time. Now I understand it is not required. Thanks. > > > > Yeah I try to ack as many as I can now, but couldn't possibly do as > many as I do if I had to build test them all, especially with my own > code to write and a family/full time non-kernel dev role. It is > certainly desirable for the majority, but if the code looks > good/correct and is a simple patch then in my mind an Acked-by is fine > to give in any case. That said, I will no doubt make mistakes on that. > > > > > Please, don't ever think I'm not more than sure that you give a lot > > of your _unpaid_ time to the kernel and I thank you very much > > I know what it means, because I too have other commitments :-) > > Thank you, and I appreciate your involvement so keep up the good work :-) > > Regards, > Phil Thanks Michael, Phil, Fabio for review.