From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FF33FC2 for ; Fri, 27 Aug 2021 16:26:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3CF5460E99; Fri, 27 Aug 2021 16:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630081589; bh=XcwTyPvhF+XagpNWN7XvIWRONRDMX7PNgx8dms2IJKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zZZwsdvfC7UF7x+yUhUHwnTwKtpiNvR4VVtzho/JTxPj4NPhZYfg0Ydm+LN7dcqjW Yo9yzWfF8ihkG8lAgVtZgd8kImnR+AljgNnmYfH0a//+/1kjFPiDIqWSYqD3irahdP lxW+FiuwQVytiAGGKS2FDN6m2OqxMboskcpEkeVE= Date: Fri, 27 Aug 2021 18:26:22 +0200 From: Greg Kroah-Hartman To: Bryan Brattlof Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem() Message-ID: References: <39bc74b0303bb31cef0ac44b9ae2b2aa7abbe645.1630080164.git.hello@bryanbrattlof.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39bc74b0303bb31cef0ac44b9ae2b2aa7abbe645.1630080164.git.hello@bryanbrattlof.com> On Fri, Aug 27, 2021 at 04:13:15PM +0000, Bryan Brattlof wrote: > The sdio_write_mem() function is unused in the driver. We can remove it. > > Signed-off-by: Bryan Brattlof > --- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 ----------- > drivers/staging/rtl8723bs/include/rtw_io.h | 1 - > 2 files changed, 12 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index a545832a468e..b784a390c8e1 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -356,16 +356,6 @@ static void sdio_read_mem( > sdio_readN(intfhdl, addr, cnt, rmem); > } > > -static void sdio_write_mem( > - struct intf_hdl *intfhdl, > - u32 addr, > - u32 cnt, > - u8 *wmem > -) > -{ > - sdio_writeN(intfhdl, addr, cnt, wmem); > -} > - > /* > * Description: > *Read from RX FIFO > @@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops) > ops->_write16 = &sdio_write16; > ops->_write32 = &sdio_write32; > ops->_writeN = &sdio_writeN; > - ops->_write_mem = &sdio_write_mem; > ops->_write_port = &sdio_write_port; > } > > diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h > index e98083a07a66..87f36b7e880f 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_io.h > +++ b/drivers/staging/rtl8723bs/include/rtw_io.h > @@ -91,7 +91,6 @@ struct _io_ops { > int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val); > > void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem); > - void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem); > > void (*_sync_irp_protocol_rw)(struct io_queue *pio_q); > > -- > 2.30.2 > > > THis changed from the previous version in ways you did not document anywhere. Please fix up in your v4 notes.