From: Greg KH <gregkh@linuxfoundation.org>
To: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Cc: hello@bryanbrattlof.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: fix docs typos and references to previous struct names
Date: Sat, 28 Aug 2021 08:12:54 +0200 [thread overview]
Message-ID: <YSnT5rXxQNE2sPvw@kroah.com> (raw)
In-Reply-To: <20210828000836.GA10188@localhost.localdomain>
On Sat, Aug 28, 2021 at 12:08:36PM +1200, Paulo Miguel Almeida wrote:
> In the comments there where some grammar mistakes and references to
> struct names that have gotten renamed over time but not reflected
> in the comments.
>
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.h | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index d5c1521192c1..1fae62c40661 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -5,16 +5,15 @@
> * userspace interface for pi433 radio module
> *
> * Pi433 is a 433MHz radio module for the Raspberry Pi.
> - * It is based on the HopeRf Module RFM69CW. Therefore inside of this
> - * driver, you'll find an abstraction of the rf69 chip.
> + * It is based on the HopeRf Module RFM69CW. Therefore, inside of this
> + * driver you'll find an abstraction of the rf69 chip.
> *
> - * If needed, this driver could be extended, to also support other
> - * devices, basing on HopeRfs rf69.
> + * If needed this driver could also be extended to support other
> + * devices based on HopeRf rf69 as well as HopeRf modules with a similar
> + * interface such as RFM69HCW, RFM12, RFM95 and so on.
> *
> - * The driver can also be extended, to support other modules of
> - * HopeRf with a similar interace - e. g. RFM69HCW, RFM12, RFM95, ...
> * Copyright (C) 2016 Wolf-Entwicklungen
> - * Marcus Wolf <linux@wolf-entwicklungen.de>
> + * Marcus Wolf <linux@wolf-entwicklungen.de>
Indentation of the name should remain here, right?
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-28 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 0:08 [PATCH] staging: pi433: fix docs typos and references to previous struct names Paulo Miguel Almeida
2021-08-28 6:12 ` Greg KH [this message]
2021-08-28 9:27 ` Paulo Miguel Almeida
2021-08-28 9:44 ` Greg KH
2021-08-28 10:00 ` Paulo Miguel Almeida
-- strict thread matches above, loose matches on Subject: below --
2021-08-28 10:12 Paulo Miguel Almeida
2021-08-28 10:23 ` Kari Argillander
2021-08-28 10:43 ` Paulo Miguel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSnT5rXxQNE2sPvw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hello@bryanbrattlof.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paulo.miguel.almeida.rodenas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox