From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B9429CA for ; Sun, 29 Aug 2021 08:10:43 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9424C608FB; Sun, 29 Aug 2021 08:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630224643; bh=9rYyvMODTtObBSqfSrojxx5ZQ0pfDpovtGm0HkyPW+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XTMOJ1BPPUlIrSn2F8oIoxKLOdios+4mn8o9NzIbO4jTn2M7EVvPyN3axtkf2tsyl GuUIKwIb4mFGDK73Kxc9dyYdIwiWj0JcF2207IKV/SXLJagOg0xp1HjUktx5OVO5Bh oekl86pa23iMYDXd2i6H5hHeDlRB266LjAYBLIhc= Date: Sun, 29 Aug 2021 10:10:33 +0200 From: Greg KH To: Saurav Girepunje Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH v3] staging: r8188eu: core: remove null check before vfree Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Aug 29, 2021 at 01:04:22PM +0530, Saurav Girepunje wrote: > Remove NULL check. NULL check before freeing function is not needed. > Correct the indentation. > > ChangeLog V3: > -Added change log. > > ChangeLog V2: > -Correct the indentation. Please put this information below the --- line, as the documentation says to do. thanks, greg k-h