From: Greg KH <gregkh@linuxfoundation.org>
To: Krish Jain <krishjain02939@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"
Date: Fri, 3 Sep 2021 19:11:20 +0200 [thread overview]
Message-ID: <YTJXOFlkLTBTg9rl@kroah.com> (raw)
In-Reply-To: <CAPGkw+xhPfD0acY1GcwPpHg=kHw7o2+y94-r3AxfzsfyqG4bDw@mail.gmail.com>
On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> >
> > Please properly line-wrap your changelog text like your editor asked you
> > to.
> >
> > Also, your subject line needs work, look at other commits for this
> > driver with:
> > git log --oneline drivers/staging/mt7621-dma/
> > and notice how they say the driver name and the subsystem.
> >
> > Please fix up and resend a v2.
> >
> > thanks,
> >
> > greg k-h
>
> Do you mean I should line-wrap (at 72 columns) the entire thing or
> only that line?
Your whole changelog text needs to be wrapped at 72 columns.
Look at the 'git log' in the kernel tree for hundreds of thousands of
examples :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-03 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 11:13 [PATCH] Fix formatting for file "hsdma-mt7621.c" Krish Jain
2021-09-02 9:09 ` Greg KH
2021-09-02 20:24 ` Krish Jain
2021-09-03 6:24 ` Greg KH
2021-09-03 15:30 ` Krish Jain
2021-09-03 15:49 ` Krish Jain
2021-09-03 17:11 ` Greg KH [this message]
2021-09-03 18:54 ` Krish Jain
2021-09-04 6:02 ` Greg KH
2021-09-04 11:11 ` Krish Jain
-- strict thread matches above, loose matches on Subject: below --
2021-09-02 11:11 Krish Jain
2021-09-01 21:37 ` Krish Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTJXOFlkLTBTg9rl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=krishjain02939@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox