From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27E53FC1
	for <linux-staging@lists.linux.dev>; Mon,  6 Sep 2021 09:45:49 +0000 (UTC)
Received: by mail.kernel.org (Postfix) with ESMTPSA id F25926069E;
	Mon,  6 Sep 2021 09:45:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1630921549;
	bh=/35z53h420eVd9x0GGMxOV6puR3UCGj0ROP/2GZkhJg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=qTSidDurVKGLtwj/gtT1DF8lJu2lpq/11xP/Ua2sEBBFrMSTqSa6KdlDFAyNK/Txs
	 T17/IpmwriF7ZFI49MU0W1CrDOVmCSUIyRvHWDSP7cUdq0HCDugpL+dFtMJ7o67QxM
	 f6qj+Fvrla5GKahJG2phieiocqVPT5BT/LpmD6y0=
Date: Mon, 6 Sep 2021 11:45:47 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: rtl8712: Move similar execution in to a
 function.
Message-ID: <YTXjSwWcyd6RRMjO@kroah.com>
References: <YTUQZdPiYFscIsvU@user>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YTUQZdPiYFscIsvU@user>

On Mon, Sep 06, 2021 at 12:15:57AM +0530, Saurav Girepunje wrote:
> Move the common execution for read_macreg_hdl, write_macreg_hdl,
> write_bbreg_hdl and write_rfreg_hdl in to a new function
> common_read_write_hdl.

You said _what_ you did here, but not _why_ you did this.

I can't easily see why you did this, please explain it better in the
next version of this patch.

thanks,

greg k-h