From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B533FC7 for ; Sat, 25 Sep 2021 08:47:31 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 25FBB6108B; Sat, 25 Sep 2021 08:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632559650; bh=jljm/gq2Uo3CFBJYUG9QFQdu6pwhLsRTik+sAfGux90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IpEehK1WCcq92jJYny4m2TX1ZNFMIm+qW3leSOGo+gF6pwjuOyi96HeqEVoNQkkm6 sMHj0fU3UcixtGiDhLpPqFDJ4hGiS7u4FUvoN1yF1cJHS0xnJ/Raz5wL2e1MGtWcAG bv1ADhAzR4K70vm7CZV91znkQ0C8nSaGPDUq4dZ4= Date: Sat, 25 Sep 2021 10:47:26 +0200 From: Greg Kroah-Hartman To: Tommaso Merciai Cc: Forest Bond , Yujia Qiao , Lucas Henneman , Madhumitha Prabakaran , Marcos Antonio de Jesus Filho , Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= , "Gustavo A. R. Silva" , Deepak R Varma , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] staging: vt6655: replace camel case b_short_slot_time instead of bShortSlotTime. Message-ID: References: <20210925074531.10446-1-tomm.merciai@gmail.com> <20210925074531.10446-2-tomm.merciai@gmail.com> <20210925084134.GA4727@tom-desktop> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210925084134.GA4727@tom-desktop> On Sat, Sep 25, 2021 at 10:41:34AM +0200, Tommaso Merciai wrote: > On Sat, Sep 25, 2021 at 10:00:04AM +0200, Greg Kroah-Hartman wrote: > > On Sat, Sep 25, 2021 at 09:45:22AM +0200, Tommaso Merciai wrote: > > > Signed-off-by: Tommaso Merciai > > > > I can not take patches without any changelog text at all, sorry. > > > > My bot pointed you at the instructions for how to write a good > > changelog, please read that before resubmitting. > > > > thanks, > > > > greg k-h > > Hi, > Thanks for your time. Sorry but I'm trying to check what I'm missing > "Versioning one patch revision" as suggested by Gustavo A. R. Silva. > > https://kernelnewbies.org/Outreachyfirstpatch > > I put Changes since vN after git format-patch "---". Maybe I'm missing > other stuff? You are missing other stuff :) Notably the actual text that goes in the git changelog that explains what this patch is doing and why it is needed. Again, please read the link that my bot pointed you at. thanks, greg k-h