[PATCH] Fix checkpatch.pl error for prism2mgmt.h

[PATCH] Fix checkpatch.pl error for prism2mgmt.h

[ua1422]

From: Usman Ansari <ua1422@gmail.com>

Signed-off-by: Usman Ansari <ua1422@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
index 17bc1ee0d498..19e648a81489 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -58,8 +58,8 @@
  *    --------------------------------------------------------------------
  */
 
-#ifndef _PRISM2MGMT_H
-#define _PRISM2MGMT_H
+ #ifndef _PRISM2MGMT_H
+ #define _PRISM2MGMT_H
 
 extern int prism2_reset_holdtime;
 extern int prism2_reset_settletime;
@@ -91,7 +91,9 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp);
  */
 
 /* byte area conversion functions*/
-void prism2mgmt_bytearea2pstr(u8 *bytearea, struct p80211pstrd *pstr, int len);
+void prism2mgmt_bytearea2pstr(u8 *bytearea,
+                              struct p80211pstrd *pstr,
+                              int len);
 
 /* byte string conversion functions*/
 void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
@@ -112,9 +114,9 @@ void prism2sta_processing_defer(struct work_struct *data);
 void prism2sta_commsqual_defer(struct work_struct *data);
 void prism2sta_commsqual_timer(struct timer_list *t);
 
-/* Interface callback functions, passing data back up to the cfg80211 layer */
+/* Interface callback, passing data back up to the cfg80211 layer */
 void prism2_connect_result(struct wlandevice *wlandev, u8 failed);
 void prism2_disconnected(struct wlandevice *wlandev);
 void prism2_roamed(struct wlandevice *wlandev);
 
-#endif
+ #endif
-- 
2.25.1

Re: [PATCH] Fix checkpatch.pl error for prism2mgmt.h

[Greg KH]

On Tue, Sep 14, 2021 at 11:38:03AM -0700, ua1422@gmail.com wrote:
> From: Usman Ansari <ua1422@gmail.com>
> 
> Signed-off-by: Usman Ansari <ua1422@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.h | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 17bc1ee0d498..19e648a81489 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -58,8 +58,8 @@
>   *    --------------------------------------------------------------------
>   */
>  
> -#ifndef _PRISM2MGMT_H
> -#define _PRISM2MGMT_H
> + #ifndef _PRISM2MGMT_H
> + #define _PRISM2MGMT_H
>  
>  extern int prism2_reset_holdtime;
>  extern int prism2_reset_settletime;
> @@ -91,7 +91,9 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp);
>   */
>  
>  /* byte area conversion functions*/
> -void prism2mgmt_bytearea2pstr(u8 *bytearea, struct p80211pstrd *pstr, int len);
> +void prism2mgmt_bytearea2pstr(u8 *bytearea,
> +                              struct p80211pstrd *pstr,
> +                              int len);
>  
>  /* byte string conversion functions*/
>  void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
> @@ -112,9 +114,9 @@ void prism2sta_processing_defer(struct work_struct *data);
>  void prism2sta_commsqual_defer(struct work_struct *data);
>  void prism2sta_commsqual_timer(struct timer_list *t);
>  
> -/* Interface callback functions, passing data back up to the cfg80211 layer */
> +/* Interface callback, passing data back up to the cfg80211 layer */
>  void prism2_connect_result(struct wlandevice *wlandev, u8 failed);
>  void prism2_disconnected(struct wlandevice *wlandev);
>  void prism2_roamed(struct wlandevice *wlandev);
>  
> -#endif
> + #endif
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] Fix checkpatch.pl error for prism2mgmt.h

[ua1422]

From: Usman Ansari <ua1422@gmail.com>

Signed-off-by: Usman Ansari <ua1422@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
index 17bc1ee0d498..19e648a81489 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -58,8 +58,8 @@
  *    --------------------------------------------------------------------
  */
 
-#ifndef _PRISM2MGMT_H
-#define _PRISM2MGMT_H
+ #ifndef _PRISM2MGMT_H
+ #define _PRISM2MGMT_H
 
 extern int prism2_reset_holdtime;
 extern int prism2_reset_settletime;
@@ -91,7 +91,9 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp);
  */
 
 /* byte area conversion functions*/
-void prism2mgmt_bytearea2pstr(u8 *bytearea, struct p80211pstrd *pstr, int len);
+void prism2mgmt_bytearea2pstr(u8 *bytearea,
+                              struct p80211pstrd *pstr,
+                              int len);
 
 /* byte string conversion functions*/
 void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
@@ -112,9 +114,9 @@ void prism2sta_processing_defer(struct work_struct *data);
 void prism2sta_commsqual_defer(struct work_struct *data);
 void prism2sta_commsqual_timer(struct timer_list *t);
 
-/* Interface callback functions, passing data back up to the cfg80211 layer */
+/* Interface callback, passing data back up to the cfg80211 layer */
 void prism2_connect_result(struct wlandevice *wlandev, u8 failed);
 void prism2_disconnected(struct wlandevice *wlandev);
 void prism2_roamed(struct wlandevice *wlandev);
 
-#endif
+ #endif
-- 
2.25.1

[PATCH] Fix checkpatch.pl error for prism2mgmt.h

[ua1422]

From: Usman Ansari <ua1422@gmail.com>

Signed-off-by: Usman Ansari <ua1422@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
index 17bc1ee0d498..19e648a81489 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -58,8 +58,8 @@
  *    --------------------------------------------------------------------
  */
 
-#ifndef _PRISM2MGMT_H
-#define _PRISM2MGMT_H
+ #ifndef _PRISM2MGMT_H
+ #define _PRISM2MGMT_H
 
 extern int prism2_reset_holdtime;
 extern int prism2_reset_settletime;
@@ -91,7 +91,9 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp);
  */
 
 /* byte area conversion functions*/
-void prism2mgmt_bytearea2pstr(u8 *bytearea, struct p80211pstrd *pstr, int len);
+void prism2mgmt_bytearea2pstr(u8 *bytearea,
+                              struct p80211pstrd *pstr,
+                              int len);
 
 /* byte string conversion functions*/
 void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
@@ -112,9 +114,9 @@ void prism2sta_processing_defer(struct work_struct *data);
 void prism2sta_commsqual_defer(struct work_struct *data);
 void prism2sta_commsqual_timer(struct timer_list *t);
 
-/* Interface callback functions, passing data back up to the cfg80211 layer */
+/* Interface callback, passing data back up to the cfg80211 layer */
 void prism2_connect_result(struct wlandevice *wlandev, u8 failed);
 void prism2_disconnected(struct wlandevice *wlandev);
 void prism2_roamed(struct wlandevice *wlandev);
 
-#endif
+ #endif
-- 
2.25.1

Re: [PATCH] Fix checkpatch.pl error for prism2mgmt.h

[Greg KH]

On Tue, Sep 14, 2021 at 04:12:32PM -0700, ua1422@gmail.com wrote:
> From: Usman Ansari <ua1422@gmail.com>
> 
> Signed-off-by: Usman Ansari <ua1422@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.h | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 17bc1ee0d498..19e648a81489 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -58,8 +58,8 @@
>   *    --------------------------------------------------------------------
>   */
>  
> -#ifndef _PRISM2MGMT_H
> -#define _PRISM2MGMT_H
> + #ifndef _PRISM2MGMT_H
> + #define _PRISM2MGMT_H
>  
>  extern int prism2_reset_holdtime;
>  extern int prism2_reset_settletime;
> @@ -91,7 +91,9 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp);
>   */
>  
>  /* byte area conversion functions*/
> -void prism2mgmt_bytearea2pstr(u8 *bytearea, struct p80211pstrd *pstr, int len);
> +void prism2mgmt_bytearea2pstr(u8 *bytearea,
> +                              struct p80211pstrd *pstr,
> +                              int len);
>  
>  /* byte string conversion functions*/
>  void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
> @@ -112,9 +114,9 @@ void prism2sta_processing_defer(struct work_struct *data);
>  void prism2sta_commsqual_defer(struct work_struct *data);
>  void prism2sta_commsqual_timer(struct timer_list *t);
>  
> -/* Interface callback functions, passing data back up to the cfg80211 layer */
> +/* Interface callback, passing data back up to the cfg80211 layer */
>  void prism2_connect_result(struct wlandevice *wlandev, u8 failed);
>  void prism2_disconnected(struct wlandevice *wlandev);
>  void prism2_roamed(struct wlandevice *wlandev);
>  
> -#endif
> + #endif
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot