From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: most: dim2: force fcnt=3 on Renesas GEN3
Date: Tue, 28 Sep 2021 09:11:49 +0200 [thread overview]
Message-ID: <YVLANRaCgY/CrYdX@kroah.com> (raw)
In-Reply-To: <20210927155804.27877-1-nikita.yoush@cogentembedded.com>
On Mon, Sep 27, 2021 at 06:58:05PM +0300, Nikita Yushchenko wrote:
> Per Renesas datasheet, MLBC0 register's fcnt field in the embedded
> dim2 module must be never set to value different from 3.
>
> Enforce that, via an optional field in struct dim2_platform_data.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> Changes from v1:
> - set dev_fcnt via if statement, not conditional expression
Much nicer, thanks!
greg k-h
next prev parent reply other threads:[~2021-09-28 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 16:51 [PATCH] staging: most: dim2: force fcnt=3 on Renesas GEN3 Nikita Yushchenko
2021-09-27 15:29 ` Greg Kroah-Hartman
2021-09-27 15:40 ` Nikita Yushchenko
2021-09-27 15:50 ` Greg Kroah-Hartman
2021-09-27 15:58 ` [PATCH v2] " Nikita Yushchenko
2021-09-28 7:11 ` Greg Kroah-Hartman [this message]
2021-09-27 16:06 ` [PATCH] staging: most: dim2: use if statements instead of ?: expressions Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVLANRaCgY/CrYdX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikita.yoush@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox