* [PATCH] staging: rtl8723bs: core: remove condition never execute
@ 2021-10-03 15:58 Saurav Girepunje
2021-10-04 7:59 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2021-10-03 15:58 UTC (permalink / raw)
To: gregkh, fabioaiuto83, ross.schm.dev, hdegoede, marcocesati,
fmdefrancesco, linux-staging, linux-kernel
Cc: saurav.girepunje
Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index b2c042c36777..3ee4d35ca8d7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE)
SetToDs(fctrl);
- if (pattrib->mdata)
- SetMData(fctrl);
-
qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
SetPriority(qc, tid);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: core: remove condition never execute
2021-10-03 15:58 [PATCH] staging: rtl8723bs: core: remove condition never execute Saurav Girepunje
@ 2021-10-04 7:59 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-10-04 7:59 UTC (permalink / raw)
To: Saurav Girepunje, gregkh, fabioaiuto83, ross.schm.dev,
marcocesati, fmdefrancesco, linux-staging, linux-kernel
Cc: saurav.girepunje
Hi,
On 10/3/21 5:58 PM, Saurav Girepunje wrote:
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index b2c042c36777..3ee4d35ca8d7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
> else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE)
> SetToDs(fctrl);
>
> - if (pattrib->mdata)
> - SetMData(fctrl);
> -
> qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
> SetPriority(qc, tid);
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-04 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-03 15:58 [PATCH] staging: rtl8723bs: core: remove condition never execute Saurav Girepunje
2021-10-04 7:59 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).