From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Dan Carpenter <dan.carpenter@oracle.com>,
Martin Kaiser <martin@kaiser.cx>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement
Date: Mon, 18 Oct 2021 16:42:51 +0200 [thread overview]
Message-ID: <YW2H63JAWKcM6+hL@kroah.com> (raw)
In-Reply-To: <20211017142812.4656-4-fmdefrancesco@gmail.com>
On Sun, Oct 17, 2021 at 04:28:12PM +0200, Fabio M. De Francesco wrote:
> Remove a redundant 'if' statement.
>
> Acked-by: Martin Kaiser <martin@kaiser.cx>
> Acked-by: Phillip Potter <phil@philpotter.co.uk>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 6 ------
> 1 file changed, 6 deletions(-)
Why is there not a "v2" in the subject line like the other patches in
this series?
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 6fb79d711692..42084b029473 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -254,12 +254,6 @@ int rtw_cmd_thread(void *context)
> while (1) {
> wait_for_completion(&pcmdpriv->enqueue_cmd);
>
> - if (padapter->bDriverStopped ||
> - padapter->bSurpriseRemoved) {
> - DBG_88E("%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
> - __func__, padapter->bDriverStopped, padapter->bSurpriseRemoved, __LINE__);
> - break;
> - }
Why is this redundant?
It is not obvious from the diff what is going on so you should say a bit
more in the changelog text please.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-18 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 14:28 [PATCH v2 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() Fabio M. De Francesco
2021-10-17 14:28 ` [PATCH v2 1/3] staging: r8188eu: Use completions for signaling start / end kthread Fabio M. De Francesco
2021-10-17 14:28 ` [PATCH v2 2/3] staging: r8188eu: Use completions for signaling enqueueing Fabio M. De Francesco
2021-10-17 14:28 ` [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement Fabio M. De Francesco
2021-10-18 14:42 ` Greg Kroah-Hartman [this message]
2021-10-18 16:28 ` Fabio M. De Francesco
2021-10-19 5:51 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2021-10-16 9:10 [PATCH 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() Fabio M. De Francesco
2021-10-16 9:10 ` [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement Fabio M. De Francesco
2021-10-16 9:59 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW2H63JAWKcM6+hL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox