From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, marcocesati@gmail.com,
saurav.girepunje@gmail.com, insafonov@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.
Date: Sun, 10 Oct 2021 10:36:05 +0530 [thread overview]
Message-ID: <YWJ0vSrgsiKK7suE@user> (raw)
Remove the unneeded and redundant check of variable on goto out.
Simplify the return using multiple goto label to avoid
unneeded check.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
ChangeLog V2:
-Add goto out after the memcpy for no error case return with
ret only. Free is not required on no error case.
ChangeLog V1:
-Remove the unneeded and redundant check of variable on
goto out.
-Simplify the return using multiple goto label to avoid
unneeded check.
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 22 +++++++++----------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 0868f56e2979..ae9579dc0848 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -2312,7 +2312,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
mon_wdev = rtw_zmalloc(sizeof(struct wireless_dev));
if (!mon_wdev) {
ret = -ENOMEM;
- goto out;
+ goto err_zmalloc;
}
mon_wdev->wiphy = padapter->rtw_wdev->wiphy;
@@ -2322,23 +2322,21 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
ret = cfg80211_register_netdevice(mon_ndev);
if (ret) {
- goto out;
+ goto err_register;
}
*ndev = pwdev_priv->pmon_ndev = mon_ndev;
memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1);
+ goto out;
-out:
- if (ret && mon_wdev) {
- kfree(mon_wdev);
- mon_wdev = NULL;
- }
-
- if (ret && mon_ndev) {
- free_netdev(mon_ndev);
- *ndev = mon_ndev = NULL;
- }
+err_register:
+ kfree(mon_wdev);
+ mon_wdev = NULL;
+err_zmalloc:
+ free_netdev(mon_ndev);
+ *ndev = mon_ndev = NULL;
+out:
return ret;
}
--
2.32.0
next reply other threads:[~2021-10-10 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 5:06 Saurav Girepunje [this message]
2021-10-10 7:24 ` [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement Fabio M. De Francesco
2021-10-11 18:10 ` Saurav Girepunje
2021-10-10 8:56 ` Pavel Skripkin
2021-10-10 12:59 ` Greg KH
2021-10-11 8:54 ` Fabio M. De Francesco
2021-10-11 12:33 ` Fabio M. De Francesco
2021-10-11 18:36 ` Saurav Girepunje
2021-10-11 17:32 ` Saurav Girepunje
2021-10-11 12:30 ` Dan Carpenter
2021-10-11 18:28 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWJ0vSrgsiKK7suE@user \
--to=saurav.girepunje@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox