From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA22A72 for ; Sun, 10 Oct 2021 07:33:02 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id a11so9106006plm.0 for ; Sun, 10 Oct 2021 00:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=ykKHrA/r2EJEyEbkVUzjv11eom1VFrBiZ2DCTiavQzo=; b=Hb/Ifoo2P85nAkYyM1k9huuKSfcZ5dXqO0RwtNc4j0IL05RnvQoitTnjX4nVoYPH28 UG3GWkEZSra0ygkWG7XZdtWayY2qEPBDGGsYb1+olWIz2q8DkLotxcwCPLGBQAor3cQ2 BvVBqZV7yBvojMEhrBTMTshx69f1SseJxynNMyYfKUnXrc1WQehZLQXd0e5a0tqcgZNK apb1Z2mMN3V5MazcRP/A6/PU+4/preXy/k644n7BO52PDc3hXPNt9BIjLvMQ65FrPBW6 f+09qr8V03hTdVyI9PTZdWiWov9VwQgCk2BBn5ouqAUxTwhvG+T7UW+kSscqrS25BTJS hMwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=ykKHrA/r2EJEyEbkVUzjv11eom1VFrBiZ2DCTiavQzo=; b=0D2cT1nCgMo/hVyd60JNeoZdc9qRcvAOrxF6hiQ+WT0DSVnn6cLHKEQpLknKCcmyJs NLwz4NlVaYU9hEJGix19a6SmiHIFWSnC1nb4/Wyt5SY5CH5XgjM+pFIsnKc/+/MjyK1K KjfgZkUFhysLpxSA7ZPDyAE1QYqGh5oZW6L5mz678LynHgzQww44nxnSWrBmiCwloOdI hDDnirfHEZt6Bbpdja8xNAvFFRizIw+GhjWvGLgtQVF9Cw6ZXNN2UV1HWhINvyMNz6ol LE/Z86HAsPIRP/9WgFon0m4/dX9Ua0pU0L4CAUPeScynX7Ac3n5KNtmquXPEH7Y4euZJ mSRA== X-Gm-Message-State: AOAM532Kn3cvSlgP72XUd88G8jWkxYJyMQTn6uCD4zr33VNvMqEO7VUg etqdtR0dhZ+aI4ARqwh0a/e1e1N0zCY= X-Google-Smtp-Source: ABdhPJyaBp/q4QLGz16KTew7U5mk6UQ/Tzhv3gHfJhX+TdLkxX9fWtvzGMYTlmsaua+7XZ3VtmslyQ== X-Received: by 2002:a17:902:e544:b0:13e:e863:6cd2 with SMTP id n4-20020a170902e54400b0013ee8636cd2mr17885504plf.41.1633851182186; Sun, 10 Oct 2021 00:33:02 -0700 (PDT) Received: from user ([223.230.43.197]) by smtp.gmail.com with ESMTPSA id 184sm3981317pfw.49.2021.10.10.00.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Oct 2021 00:33:01 -0700 (PDT) Date: Sun, 10 Oct 2021 13:02:56 +0530 From: Saurav Girepunje To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, marcocesati@gmail.com, dan.carpenter@oracle.com, lee.jones@linaro.org, saurav.girepunje@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Subject: [PATCH] staging: rtl8723bs: hal: remove if condition which is always false Message-ID: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Remove the if condition which is always false. The last update on variable max_rf_path is value 1. It's value is not changing after that. So if condition check for value 2 will be always false only. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c index 392cc8a398f5..612575ba961a 100644 --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c @@ -106,12 +106,10 @@ static s16 odm_InbandNoise_Monitor_NSeries( pDM_Odm->noise_level.noise[RF_PATH_A] = -110 + reg_c50 + noise_data.sum[RF_PATH_A]; pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_A]; - if (max_rf_path == 2) { - reg_c58 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0); - reg_c58 &= ~BIT7; - pDM_Odm->noise_level.noise[RF_PATH_B] = -110 + reg_c58 + noise_data.sum[RF_PATH_B]; - pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_B]; - } + reg_c58 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0); + reg_c58 &= ~BIT7; + pDM_Odm->noise_level.noise[RF_PATH_B] = -110 + reg_c58 + noise_data.sum[RF_PATH_B]; + pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_B]; pDM_Odm->noise_level.noise_all /= max_rf_path; /* */ -- 2.32.0