From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84B32C81 for ; Wed, 13 Oct 2021 22:50:33 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id i1so4168050qtr.6 for ; Wed, 13 Oct 2021 15:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xM1fMd37P0GkH+ZlVvAIHq/XlgyRCHndX09GA3o6I2w=; b=sV74+qP2MQF6w9NmafHoTpTolVfVwa0rljewKiYT94oDqfz0A5uHEVwWv2+SmELSHc tWi6VdT69T4pL6mhUtsPnJwakwfrCd8tASkny/rtRx3bV5bZnliB+S91yJtXbcd4cJsP CEhnBkaQthmsfom4VTyB5PDG8CoKhTHAi0ufvApv/LElVrWx/9vAwQnuQ4FIx80EIjgr yeORRy5s1q4pLKS0K3IRbLLUlzgFwOrD4yiBCTNTw7+G6ykXocghAiFCj3U3+GBI2e/7 5awydk+SNqULo5yRmsVegI6pH+Cn83rFSzSS36NqX0k3ET+lDcgZ6BH/8i5vOlv2eUAo Kakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xM1fMd37P0GkH+ZlVvAIHq/XlgyRCHndX09GA3o6I2w=; b=Gd3lOrbmygzbfIJBKmErFkt0d+bPkHe3DiiWUTciBD1yeWgpvEHMKh3JX+nKFEOKtq P0+aAe2+N+FYR9Ttbcsry7HH0E3vFk/CWeQZsJkGONGUlYIjCgq5BBizaTqruMws+sAr 9JjeXe+RXZdV9h5s+Nd1cadIxvbXPFWpSE8QU9vzOjp9qB/b2g+KmQqbapoxPF+D/zCG UqvC2jGgALdA0gl90tTYC9WQDiXH0ygn2s9hGAVAhziFzAZRXIVtKFPrEbBkQDiTec/C CYHkpLV7aROInC5nBmBRHdE1bdCLv28DcAWCXcZLkXOSh8fKlXzWs41k/UXAFQSQFu4L Px1Q== X-Gm-Message-State: AOAM532oG3+8n7sOUgi2jFC2BnY/a61LKZgSCL3Eigq64ofGfNDL+r5j f6HlxrptYakBjr4vxfmo55NPUA== X-Google-Smtp-Source: ABdhPJyMyktfWBfUtcNLXQN+ND/84ayn5d3dsHNkBD7ZxYgHVbjL6ZghrpM+UN8x+hQpM+G+IwpnBw== X-Received: by 2002:ac8:7f44:: with SMTP id g4mr2516291qtk.130.1634165432864; Wed, 13 Oct 2021 15:50:32 -0700 (PDT) Received: from fedora ([196.32.91.248]) by smtp.gmail.com with ESMTPSA id g11sm606454qko.31.2021.10.13.15.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 15:50:31 -0700 (PDT) Date: Wed, 13 Oct 2021 19:50:27 -0300 From: Ezequiel Garcia To: Rikard Falkeborn Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops Message-ID: References: <20211012221144.30638-1-rikard.falkeborn@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012221144.30638-1-rikard.falkeborn@gmail.com> On Wed, Oct 13, 2021 at 12:11:44AM +0200, Rikard Falkeborn wrote: > The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), > which takes a pointer to const v4l2_m2m_ops as argument. Make it const > to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn Reviewed-by: Ezequiel Garcia > --- > drivers/staging/media/rkvdec/rkvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index bf00fe6534a3..28aab5c7fe33 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) > rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); > } > > -static struct v4l2_m2m_ops rkvdec_m2m_ops = { > +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { > .device_run = rkvdec_device_run, > }; > > -- > 2.33.0 >