From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F922C83 for ; Sat, 16 Oct 2021 15:27:44 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id g2so4720102wme.4 for ; Sat, 16 Oct 2021 08:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1d8J0Orw/hk2ukRu7tKUFBvEuXpF7xwwE6uX/V+ILtU=; b=5jh2oic+IgJVmmhSYdguTK1DWEdkkhGOKGYWwNxC+m3+0xcjCmuVHvaN52Io94u8tk mG0+Fe2OEg6ms8/wKQkUuW6nLIvu4zugBI1WQMwinOZuwKrAXhVQMHZYghaqkBJQ2A/q 7DWzlm7ZezTe/oXCAzGxYce48fO8xyWkPmEClXTEk58lY2TBCLSkjknrFjBU9gDTz+yv gzc4pAQ5Tf3/hokbMFtdAPwOQbv/KRvofgucgMXDC+CFqXOfiyzZWdCuSOZKwjoVPnXC T+NLhGiGauuHO/cQlwkzb2Vrp92ALTbMg8iUP+bXyqJqfFtDveI8dfmrcT6mQ+ID1r6b HkPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1d8J0Orw/hk2ukRu7tKUFBvEuXpF7xwwE6uX/V+ILtU=; b=fnLfrX6bzj7fwmHlRv0G4hQ41ASLmg5o6YnqviqX25pSZyGYiIzgqp/xOPLqxQ1s5s Ta/qUSFyVKf61bkSxlvNJBdbWQoQWNIAE+qRUX2PgAIP0+PmVasq9LZGz7kk6VpHvVFB 5waHrBThY2ZhOZERMz45FgXMemAZYo0l/d7yNaellyvhXHn5V940CcvXtGVBs0W45Ksg 6LKFZ/lyqudtdkqtNCRHDnh9rkpe3qnqV5aJS9gC083aC9lanAGsXz8gaVWK0a5Fm97M elcB2LfNELyFZqqwN41y0N66qBK/KOvneXGQD8TpwS/6wn2aX8831arqap/+uy6+B9HQ C0tw== X-Gm-Message-State: AOAM530P/YyodKS19bs3v7JzrhuR5pcT08BNYONUp5hGkRdVk/nucaGC fy6Ro1vrUk22fju2j0/43WcBFA== X-Google-Smtp-Source: ABdhPJzgI1Y1ZxagsGxK7AqFA7XKRlD93cZM/p2/C6fvciCpi0Pe0UH0RiglOr6HOfP+77rDnOUkbg== X-Received: by 2002:a1c:4c19:: with SMTP id z25mr33755674wmf.0.1634398063142; Sat, 16 Oct 2021 08:27:43 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id j1sm8988536wrb.56.2021.10.16.08.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Oct 2021 08:27:42 -0700 (PDT) Date: Sat, 16 Oct 2021 16:27:40 +0100 From: Phillip Potter To: "Fabio M. De Francesco" Cc: Larry Finger , Greg Kroah-Hartman , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() Message-ID: References: <20211016091042.19614-1-fmdefrancesco@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211016091042.19614-1-fmdefrancesco@gmail.com> On Sat, Oct 16, 2021 at 11:10:39AM +0200, Fabio M. De Francesco wrote: > This series replaces two semaphores with three completion variables > in rtw_cmd_thread(). Completions variables are better suited for the > purposes that are explained in detail in the commit messages of patches > 1/3 and 2/3. Furthermore, patch 3/3 removes a redundant 'if' statement > from that same rtw_cmd_thread(). > > Tested with ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano] > > Many thanks to Dan Carpenter who helped with > his review of the RFC Patch. > > Fabio M. De Francesco (3): > staging: r8188eu: Use completions for signaling start and end of > kthread > staging: r8188eu: Use completions for signaling enqueueing of commands > staging: r8188eu: Remove redundant 'if' statement > > drivers/staging/r8188eu/core/rtw_cmd.c | 19 +++++++------------ > drivers/staging/r8188eu/include/rtw_cmd.h | 5 +++-- > drivers/staging/r8188eu/os_dep/os_intfs.c | 8 +++++--- > 3 files changed, 15 insertions(+), 17 deletions(-) > > -- > 2.33.0 > Dear Fabio, Built and tested on my USB-N10 Nano, working well. In terms of how you've split the patches out, I have no problem with it personally, given that one semaphore was there for kthread start/stop and the other for queuing. Looks good to me anyway based on what I know of completion variables :-) I assume you've not made the waits killable or interruptible in patch 1 due to the fact they are specifically related to kthread start/stop? Anyhow: For whole series: Acked-by: Phillip Potter Regards, Phil