Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Goller <gabrielgoller123@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: Cleanup fix parenthesis alignment
Date: Sat, 30 Oct 2021 11:50:41 +0200	[thread overview]
Message-ID: <YX0VcfPnHTBAyMiZ@kroah.com> (raw)
In-Reply-To: <YX0Ut9BaVBQk5Z/g@desktop>

On Sat, Oct 30, 2021 at 11:47:35AM +0200, Gabriel Goller wrote:
> This patch fixes some style-warnings of checkpatch.pl:
> Alignment should match open parenthesis.
> 
> Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 7951bd63816f..de2980c69711 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -476,8 +476,8 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>  				return -EINVAL;
>  
>  			result = prism2_domibset_uint32(wlandev,
> -				DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> -				sme->key_idx);
> +							DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,

And now you added another checkpatch.pl warning?

Please do not make changes that do this.

thanks,

greg k-h

      reply	other threads:[~2021-10-30  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30  9:47 [PATCH] staging: wlan-ng: Cleanup fix parenthesis alignment Gabriel Goller
2021-10-30  9:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YX0VcfPnHTBAyMiZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gabrielgoller123@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox