Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Goller <gabrielgoller123@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: Fix formatting of block comments
Date: Sat, 30 Oct 2021 12:22:11 +0200	[thread overview]
Message-ID: <YX0c00VaVrcbD2UE@kroah.com> (raw)
In-Reply-To: <YX0Zmb6Osu3tODfJ@desktop>

On Sat, Oct 30, 2021 at 12:08:25PM +0200, Gabriel Goller wrote:
> Fixed warnings of checkpatch.pl in prism2mib.c:
> Block comments use * on subsequent lines.
> 
> Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index 24ba10d6bd0b..c04fc17b3c64 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
>  					       (u8 *)&wpa,
>  					       sizeof(wpa));
>  			/*
> -			pstr->len = le16_to_cpu(wpa.datalen);
> -			memcpy(pstr->data, wpa.data, pstr->len);
> -			*/
> +			 * pstr->len = le16_to_cpu(wpa.datalen);
> +			 * memcpy(pstr->data, wpa.data, pstr->len);
> +			 */

Why keep this code at all?  Please just delete it as it's obviously not
being used.

thanks,

greg k-h

      reply	other threads:[~2021-10-30 10:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 10:08 [PATCH] staging: wlan-ng: Fix formatting of block comments Gabriel Goller
2021-10-30 10:22 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YX0c00VaVrcbD2UE@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gabrielgoller123@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox