From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5542C8B for ; Wed, 20 Oct 2021 21:05:38 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id i12so156747wrb.7 for ; Wed, 20 Oct 2021 14:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T77iytDqhp9H0uodyxGcNpBMzkLQE3z2HpWpG8HbcZ4=; b=sSOED3ext07+4nJWteaYcNEQpXkMHR+7NP8nSkpFJJ+PCQ5xTB7Lc4baz8r86FngQ7 RdFKodfn+ciAlrGMUXxrpRUggJrLLwdUXAjhRLj8xlyjoJ9wcELO9poiNoNdo8Z4gdLJ 5pfKmNG8Ce576vBNrPQaueaD1KkweblneiD5WnFM07LyieOUqPX6v2qwSxvYy32n+yTi 1CJotex6FafvIj/UKJA2MuuLVvziYRHFZHExEm1WQXJsgAh4CHxZXAQK8RFm64CjSyMs ZpRML0V3oEBt0RhSxn7I8uk50fsBXEbDCPRnspva8Cb+4ecJTjnfHsOzJVg6yvVcaB7O ic5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T77iytDqhp9H0uodyxGcNpBMzkLQE3z2HpWpG8HbcZ4=; b=XiPcsORrkGS1Q2N+TN3AXaoshUELGwx+wd5m2EKr/zXGaonRbFYruEXUCDXeheF6KS k+lXTQgncpMViVphjUmbq/2Q7GSdiRktFaL7X2Ns9bx6ldQx7Z9bg7UJpAi9emsRN1WO jKp0WvEhOHqM7OKTXA2pa6CzC7zQGrstFBif+xYbr+D+epowcBWp1wUK6DUHaSAOJ7RO 447MxEbExMKtCmt0+ST6QqhHDZ6LnnyzOB/0JWQ06KTPHvCehoETp/XjG8hCTyiIjt07 COpl2gDhVq0rKEJiXWgVW27aAob7UX8EKskFEpp37I4tQBiHAK2bPLOcFSWySbq+IKaB Wl8Q== X-Gm-Message-State: AOAM530jPMcakdErjo2hMKfINa/V6tZ0rFEbi3xdmISw9Y5Zbe5IaWxU 2L+CH32nHajFbTQUGcb7X84rtQ== X-Google-Smtp-Source: ABdhPJyzhaESlmMmaDyssgwpQ833qQsnwkKEQjQHodZ7elzBJAnWEQaqACu1XYq1NWVkDlfQDXLG7g== X-Received: by 2002:adf:a48e:: with SMTP id g14mr2008477wrb.11.1634763936696; Wed, 20 Oct 2021 14:05:36 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id o10sm3398416wmq.46.2021.10.20.14.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 14:05:35 -0700 (PDT) Date: Wed, 20 Oct 2021 22:05:34 +0100 From: Phillip Potter To: Martin Kaiser Cc: Greg Kroah-Hartman , Larry Finger , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: r8188eu: remove unused dm_priv components Message-ID: References: <20211020195401.12931-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020195401.12931-1-martin@kaiser.cx> On Wed, Oct 20, 2021 at 09:53:57PM +0200, Martin Kaiser wrote: > Remove unused components from struct dm_priv. > > DMFlag is only written to, but never read. > InitDMFlag is assigned to DMFlag and not used elsewhere. > DM_Type is also write-only. > UndecoratedSmoothedPWDB and UndecoratedSmoothedCCK are not used at all. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/hal/rtl8188e_dm.c | 3 --- > drivers/staging/r8188eu/hal/usb_halinit.c | 1 - > drivers/staging/r8188eu/include/rtl8188e_dm.h | 5 ----- > 3 files changed, 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c > index 4ce2c3749665..5d76f6ea91c4 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c > @@ -87,12 +87,9 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) > void rtl8188e_InitHalDm(struct adapter *Adapter) > { > struct hal_data_8188e *hal_data = GET_HAL_DATA(Adapter); > - struct dm_priv *pdmpriv = &hal_data->dmpriv; > struct odm_dm_struct *dm_odm = &hal_data->odmpriv; > > dm_InitGPIOSetting(Adapter); > - pdmpriv->DM_Type = DM_Type_ByDriver; > - pdmpriv->DMFlag = DYNAMIC_FUNC_DISABLE; > Update_ODM_ComInfo_88E(Adapter); > ODM_DMInit(dm_odm); > Adapter->fix_rate = 0xFF; > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index cdc602fa9af8..ef1ae95d7db0 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -1469,7 +1469,6 @@ void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val) > break; > case HW_VAR_DM_FUNC_SET: > if (*((u32 *)val) == DYNAMIC_ALL_FUNC_ENABLE) { > - pdmpriv->DMFlag = pdmpriv->InitDMFlag; > podmpriv->SupportAbility = pdmpriv->InitODMFlag; > } else { > podmpriv->SupportAbility |= *((u32 *)val); > diff --git a/drivers/staging/r8188eu/include/rtl8188e_dm.h b/drivers/staging/r8188eu/include/rtl8188e_dm.h > index 4a0608313f7a..208bea050f6f 100644 > --- a/drivers/staging/r8188eu/include/rtl8188e_dm.h > +++ b/drivers/staging/r8188eu/include/rtl8188e_dm.h > @@ -15,14 +15,9 @@ enum{ > #define HP_THERMAL_NUM 8 > /* duplicate code,will move to ODM ######### */ > struct dm_priv { > - u8 DM_Type; > - u8 DMFlag; > - u8 InitDMFlag; > u32 InitODMFlag; > > /* Upper and Lower Signal threshold for Rate Adaptive*/ > - int UndecoratedSmoothedPWDB; > - int UndecoratedSmoothedCCK; > int EntryMinUndecoratedSmoothedPWDB; > int EntryMaxUndecoratedSmoothedPWDB; > int MinUndecoratedPWDBForDM; > -- > 2.20.1 > Looks good. Acked-by: Phillip Potter Regards, Phil