linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kushal Kothari <kushalkothari285@gmail.com>
Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
	fmdefrancesco@gmail.com, marcocesati@gmail.com,
	straube.linux@gmail.com, philippesdixon@gmail.com,
	manuelpalenzuelamerino@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, mike.rapoport@gmail.com,
	kushalkotharitest@googlegroups.com,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines
Date: Fri, 22 Oct 2021 08:03:35 +0200	[thread overview]
Message-ID: <YXJUNy0VXEwxeBe+@kroah.com> (raw)
In-Reply-To: <f6d2ba1d544c70519bad5c04f012cba0214b379a.1634845504.git.kushalkothari285@gmail.com>

On Fri, Oct 22, 2021 at 01:27:53AM +0530, Kushal Kothari wrote:
> Remove useless blank lines
> 
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index fce3256cc275..690e4627663c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -316,8 +316,6 @@ int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
>  	return _SUCCESS;
>  }
>  
> -
> -
>  int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
>  {
>  	int res = _FAIL;
> @@ -367,7 +365,6 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd)
>  	kfree(pcmd);
>  }
>  
> -
>  void rtw_stop_cmd_thread(struct adapter *adapter)
>  {
>  	if (adapter->cmdThread &&
> @@ -735,8 +732,7 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
>  	}
>  	/* for ies is fix buf size */
>  	t_len = sizeof(struct wlan_bssid_ex);
> -
> -
> +	

Please do not add new whitespace errors :(

Always run your patches through checkpatch.pl to ensure this.

thanks,

greg k-h

  reply	other threads:[~2021-10-22  6:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 19:57 [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Kushal Kothari
2021-10-21 19:57 ` [PATCH 1/4] staging: rtl8723bs: core: Remove true and false comparison Kushal Kothari
2021-10-22  2:44   ` [Outreachy kernel] " Praveen Kumar
2021-11-03 11:52     ` Dan Carpenter
2021-10-21 19:57 ` [PATCH 2/4] staging: rtl8723bs: core: Remove unnecessary parentheses Kushal Kothari
2021-10-21 19:57 ` [PATCH 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast Kushal Kothari
2021-10-22  2:48   ` [Outreachy kernel] " Praveen Kumar
2021-10-21 19:57 ` [PATCH 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines Kushal Kothari
2021-10-22  6:03   ` Greg KH [this message]
2021-10-22  2:45 ` [Outreachy kernel] [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Praveen Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXJUNy0VXEwxeBe+@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fabioaiuto83@gmail.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=kushalkothari285@gmail.com \
    --cc=kushalkotharitest@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manuelpalenzuelamerino@gmail.com \
    --cc=marcocesati@gmail.com \
    --cc=mike.rapoport@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=philippesdixon@gmail.com \
    --cc=ross.schm.dev@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).