From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
will+git@drnd.me, mitaliborkar810@gmail.com,
eduard.vintila47@gmail.com, saurav.girepunje@gmail.com,
zhaoxiao@uniontech.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: [PATCH] staging: rtl8192e: remove condition with no effect
Date: Thu, 28 Oct 2021 00:04:43 +0530 [thread overview]
Message-ID: <YXmap8VIxfOpqeEY@Sauravs-MacBook-Air.local> (raw)
Remove the if and else code section for variable pHTInfo->bRegBW40MHz.
Just before the if condition variable is assign with value 1.
So if condition check for pHTInfo->bRegBW40MHz is always true.
Similarly for the variable pHTInfo->SelfMimoPs value '3' is assign.
So if condition check with value '2' will never be true. Remove the
if condition check for pHTInfo->SelfMimoPs.
Remove the extra blank lines from HTUpdateDefaultSetting function.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 3b8efaf9b88c..6925654dbc03 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -72,34 +72,20 @@ void HTUpdateDefaultSetting(struct rtllib_device *ieee)
struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
pHTInfo->bAcceptAddbaReq = 1;
-
pHTInfo->bRegShortGI20MHz = 1;
pHTInfo->bRegShortGI40MHz = 1;
-
pHTInfo->bRegBW40MHz = 1;
-
- if (pHTInfo->bRegBW40MHz)
- pHTInfo->bRegSuppCCK = 1;
- else
- pHTInfo->bRegSuppCCK = true;
-
+ pHTInfo->bRegSuppCCK = 1;
pHTInfo->nAMSDU_MaxSize = 7935UL;
pHTInfo->bAMSDU_Support = 0;
-
pHTInfo->bAMPDUEnable = 1;
pHTInfo->AMPDU_Factor = 2;
pHTInfo->MPDU_Density = 0;
-
pHTInfo->SelfMimoPs = 3;
- if (pHTInfo->SelfMimoPs == 2)
- pHTInfo->SelfMimoPs = 3;
ieee->bTxDisableRateFallBack = 0;
ieee->bTxUseDriverAssingedRate = 0;
-
ieee->bTxEnableFwCalcDur = 1;
-
pHTInfo->bRegRT2RTAggregation = 1;
-
pHTInfo->bRegRxReorderEnable = 1;
pHTInfo->RxReorderWinSize = 64;
pHTInfo->RxReorderPendingTime = 30;
--
2.33.0
next reply other threads:[~2021-10-27 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 18:34 Saurav Girepunje [this message]
2021-10-30 9:15 ` [PATCH] staging: rtl8192e: remove condition with no effect Greg KH
2021-10-31 18:58 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXmap8VIxfOpqeEY@Sauravs-MacBook-Air.local \
--to=saurav.girepunje@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=eduard.vintila47@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitaliborkar810@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=will+git@drnd.me \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox