From: Greg KH <gregkh@linuxfoundation.org>
To: Liu Junqi <liujunqi@pku.edu.cn>
Cc: linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line
Date: Sat, 13 Nov 2021 09:02:23 +0100 [thread overview]
Message-ID: <YY9xD1K0cUpc5iCW@kroah.com> (raw)
In-Reply-To: <20211113052815.358793-1-liujunqi@pku.edu.cn>
On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
> ---
> drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index 1424d01d434b..282fc807d0de 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> spin_unlock_bh(&chan->vchan.lock);
> }
>
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> - size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor
> +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
No, this is now worse looking. The original was not pretty, but better
than this.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-13 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 5:28 [PATCH] Staging: mt7621-dma: reindent to avoid '(' at the end of line Liu Junqi
2021-11-13 8:02 ` Greg KH [this message]
2021-11-13 8:19 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY9xD1K0cUpc5iCW@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=liujunqi@pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox