Re: r8188eu driver in 5.15 only shows wifi networks on channel 11

Larry Finger
2021-11-06T17:44:14Z

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On 11/6/21 10:48, Zameer Manji wrote:
> Hello All,
>
> I have bisected the regression to
> ```
> commit 221abd4d478ab52fd17de9287fa302ac0e06f7b3
> Author: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Date: Thu Aug 12 02:25:19 2021 +0200
>
> staging: r8188eu: Remove no more necessary definitions and code
> ```
>
> Prior to this change the device can see all networks on all channels.
> With this change, the device can only see networks on channel 11.
> I suspect this might be specific to the RTL8188EUS variant
> of the hardware. Unfortunately I don't know enough about
> this driver or the hardware to understand where the issue
> is in the change.

Zameer,

No this problem is not due to the EUS variant. In fact, I have one of those, and
I suspect most users do.

Thanks again for the bisection, which is most helpful. I have identified what I
think is a problem with the offending patch. An entry was removed from one of
the tables when it should have been replaced with a zero value in that location.
Attached is a patch for testing. Please apply it and report your results.
Meanwhile, I will look to verify that there are no other similar problems.

Thanks,

Larry

[-- Attachment #2: test_patch.patch --]
[-- Type: text/x-patch, Size: 673 bytes --]

diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 55c3d4a6faeb..f5c9a645c682 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -107,6 +107,7 @@ static struct rt_channel_plan_map RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = {
{0x01}, /* 0x10, RT_CHANNEL_DOMAIN_JAPAN */
{0x02}, /* 0x11, RT_CHANNEL_DOMAIN_FCC_NO_DFS */
{0x01}, /* 0x12, RT_CHANNEL_DOMAIN_JAPAN_NO_DFS */
+ (0x00), /* 0x13 */
{0x02}, /* 0x14, RT_CHANNEL_DOMAIN_TAIWAN_NO_DFS */
{0x00}, /* 0x15, RT_CHANNEL_DOMAIN_ETSI_NO_DFS */
{0x00}, /* 0x16, RT_CHANNEL_DOMAIN_KOREA_NO_DFS */