From: Phillip Potter <phil@philpotter.co.uk>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Zameer Manji <zmanji@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev,
Larry Finger <Larry.Finger@lwfinger.net>,
Martin Kaiser <martin@kaiser.cx>,
Michael Straube <straube.linux@gmail.com>
Subject: Re: r8188eu driver in 5.15 only shows wifi networks on channel 11
Date: Sat, 6 Nov 2021 23:05:10 +0000 [thread overview]
Message-ID: <YYcKJrFjPvP/tN2u@equinox> (raw)
In-Reply-To: <1977263.McJW3uIAVl@localhost.localdomain>
On Sat, Nov 06, 2021 at 11:17:44PM +0100, Fabio M. De Francesco wrote:
> On Saturday, November 6, 2021 8:26:35 PM CET Pavel Skripkin wrote:
> >
> > We need to review code better to prevent accidentally regressions
> >
> > Thanks for bisection and your report
> >
> Hello everybody,
>
> I've just read this thread and I'm sorry for introducing a regression with
> commit 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions
> and code").
>
Dear Fabio,
This is an honest mistake, and you shouldn't worry - anyone of us could
have done the same thing. You have contributed hugely to this driver,
and we are all better off as a community for it :-)
Even with all of us checking each others code, things like this will slip
through, this is just the nature of the process. We are all human after
all. I am looking forward to seeing more of your excellent work! :-)
Regards,
Phil
prev parent reply other threads:[~2021-11-06 23:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 4:34 r8188eu driver in 5.15 only shows wifi networks on channel 11 Zameer Manji
2021-11-05 9:20 ` Pavel Skripkin
2021-11-05 21:03 ` Zameer Manji
2021-11-06 0:29 ` Phillip Potter
2021-11-06 8:32 ` Pavel Skripkin
2021-11-06 9:48 ` Pavel Skripkin
2021-11-06 13:21 ` Zameer Manji
2021-11-06 15:48 ` Zameer Manji
2021-11-06 16:59 ` Phillip Potter
2021-11-06 17:16 ` Zameer Manji
2021-11-06 18:09 ` Larry Finger
2021-11-06 18:30 ` Phillip Potter
2021-11-06 18:49 ` Phillip Potter
2021-11-06 19:29 ` Zameer Manji
2021-11-06 19:46 ` Larry Finger
2021-11-06 19:56 ` Zameer Manji
2021-11-06 21:33 ` Phillip Potter
2021-11-06 17:44 ` Larry Finger
2021-11-06 17:52 ` Larry Finger
2021-11-06 19:26 ` Pavel Skripkin
2021-11-06 22:17 ` Fabio M. De Francesco
2021-11-06 23:05 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYcKJrFjPvP/tN2u@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=straube.linux@gmail.com \
--cc=zmanji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox