From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB672CA6 for ; Thu, 16 Dec 2021 21:07:51 +0000 (UTC) Received: by mail-ot1-f53.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso386520otf.12 for ; Thu, 16 Dec 2021 13:07:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cx2O43LmNvC8GyZN+btCibCu9iyCGJB6KtMGjIeaSF8=; b=HYmWc/Vl0luL+lnOp/M8G1NWx6xduR0ad08pKOZGcipFphqDlEnWdlajP8JldEyz/1 2q1a+rQ/cBbWW7O+Rn8eAgmXYSXj+bLVY16rR7xrXVnkDcdo8WjnXkKHTjwwdSASCq7a cIECrUrfDqyt2fuv2w6UbvwCICGSwi+IJdBsp+7+/cBiZ7tD63N93IYZbbIpNpuRKy+X Qa/7EqsKz2wctV3Dr3ErzOPrIzb/MWkxpa8eScwAt4XpM4idyc4U9jJcV13R7ME5gOCb pH46VDbYOSaWCnO9f+IrF0FhZYyibjHKYzWNrRr3CwwLXMOF2mN8AZcvrfOFCQY4NAyR KXZQ== X-Gm-Message-State: AOAM533W51SaPV51wc/GH4RRsHvVqMlELffk7P22lyyBDler3ZcYSfl1 K4b0xgrxlU6uxcLN+Ue0QA== X-Google-Smtp-Source: ABdhPJwpr9IO7zj4qWR3cuBfdUVvEAAstbCB8u01288B7/rYhH2qI+Lua/zGG9hBO0hoFbVeIQE+3w== X-Received: by 2002:a9d:1ca9:: with SMTP id l41mr14278100ota.341.1639688870339; Thu, 16 Dec 2021 13:07:50 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 184sm1194863oih.58.2021.12.16.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 13:07:50 -0800 (PST) Received: (nullmailer pid 764267 invoked by uid 1000); Thu, 16 Dec 2021 21:07:49 -0000 Date: Thu, 16 Dec 2021 15:07:49 -0600 From: Rob Herring To: Adam Ford Cc: linux-media@vger.kernel.org, abel.vesa@nxp.com, aford@beaconembedded.com, benjamin.gaignard@collabora.com, hverkuil-cisco@xs4all.nl, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , Lucas Stach , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH V2 08/10] dt-bindings: media: nxp,imx8mq-vpu: Add support for G1 and G2 on imx8mm Message-ID: References: <20211216111256.2362683-1-aford173@gmail.com> <20211216111256.2362683-9-aford173@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211216111256.2362683-9-aford173@gmail.com> On Thu, Dec 16, 2021 at 05:12:53AM -0600, Adam Ford wrote: > The i.MX8M mini appears to have a similar G1 and G2 decoder but the > post-procesing isn't present, so different compatible flags are requred. post-processing > Since all the other parameters are the same with imx8mq, just add > the new compatible flags to nxp,imx8mq-vpu.yaml. > > Signed-off-by: Adam Ford > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > index c1e157251de7..b1f24c48c73b 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > @@ -5,7 +5,7 @@ > $id: "http://devicetree.org/schemas/media/nxp,imx8mq-vpu.yaml#" > $schema: "http://devicetree.org/meta-schemas/core.yaml#" > > -title: Hantro G1/G2 VPU codecs implemented on i.MX8MQ SoCs > +title: Hantro G1/G2 VPU codecs implemented on i.MX8MQ/i.MX8MM SoCs Just 'i.MX8' so we don't have to change this everytime? > > maintainers: > - Philipp Zabel > @@ -20,6 +20,8 @@ properties: > deprecated: true > - const: nxp,imx8mq-vpu-g1 > - const: nxp,imx8mq-vpu-g2 > + - const: nxp,imx8mm-vpu-g1 > + - const: nxp,imx8mm-vpu-g2 Not compatible with the imx8mq variants? > > reg: > maxItems: 1 > @@ -66,3 +68,27 @@ examples: > clocks = <&clk IMX8MQ_CLK_VPU_G2_ROOT>; > power-domains = <&vpu_blk_ctrl IMX8MQ_VPUBLK_PD_G2>; > }; > + - | > + #include > + #include > + #include > + > + vpu_g1: video-codec@38300000 { > + compatible = "nxp,imx8mm-vpu-g1"; > + reg = <0x38300000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MM_CLK_VPU_G1_ROOT>; > + power-domains = <&vpu_blk_ctrl IMX8MM_VPUBLK_PD_G1>; > + }; > + - | > + #include > + #include > + #include > + > + vpu_g2: video-codec@38300000 { > + compatible = "nxp,imx8mm-vpu-g2"; > + reg = <0x38310000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MM_CLK_VPU_G2_ROOT>; > + power-domains = <&vpu_blk_ctrl IMX8MM_VPUBLK_PD_G2>; > + }; No point in more examples just for a different compatible. > -- > 2.32.0 > >