From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 063E1173 for ; Mon, 20 Dec 2021 16:39:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C9A9C36AF7; Mon, 20 Dec 2021 16:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640018360; bh=TwNNfoMA/Zn3DehtozWj5LYPABBiZWDOxvsgDGzs+ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vj3FIbPGlSQsSsUmKCI7mROpgen35CW65onA9Leof2FwOd/IaI2EwWMfxYH0iBCvP Pd4ePfWaSc79+iKSxg/HXo2tubo0VH70UDtSlMi4D4/FLcFYmU+loK5z00RYt8qFB9 JKUQt18Y+BVAOzW5J3/sDQgUIIp9Lu0HinTNv4V8= Date: Mon, 20 Dec 2021 17:39:18 +0100 From: Greg Kroah-Hartman To: Tommaso Merciai Cc: linuxfancy@googlegroups.com, Forest Bond , Alberto Merciai , Karolina Drobnik , Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h Message-ID: References: <20211219182004.25656-1-tomm.merciai@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211219182004.25656-1-tomm.merciai@gmail.com> On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote: > Drop off unused variable byRxMode in device.h, this fix following > checkpatch.pl check: > > CHECK: Avoid CamelCase: > 131: FILE: drivers/staging/vt6655/device.h:131: > unsigned char byRxMode > > Signed-off-by: Tommaso Merciai > --- > drivers/staging/vt6655/device.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h > index 4706bde1ec1d..84b1dcf80e47 100644 > --- a/drivers/staging/vt6655/device.h > +++ b/drivers/staging/vt6655/device.h > @@ -128,8 +128,6 @@ struct vnt_private { > u32 memaddr; > u32 ioaddr; > > - unsigned char byRxMode; > - > spinlock_t lock; > > volatile int iTDUsed[TYPE_MAXTD]; > -- > 2.25.1 > > Did you send this twice? What is the difference between the two versions? And you have trailing whitespace in the changelog for this message, please fix. thanks, greg k-h