Re: [PATCH] qlge: replace goto

[Greg KH <greg@kroah.com>]

On Mon, Dec 27, 2021 at 10:55:42AM +0300, Adam Kandur wrote:
> I think this goto can be easily replaced. Hope, this is right.
> 
> ---
>  drivers/staging/qlge/qlge_mpi.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 96a4de6d2b34..b739dd051c87 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -1122,7 +1122,8 @@ void qlge_mpi_port_cfg_work(struct work_struct *work)
>         if (status) {
>                 netif_err(qdev, drv, qdev->ndev,
>                           "Bug: Failed to get port config data.\n");
> -               goto err;
> +               clear_bit(QL_PORT_CFG, &qdev->flags);
> +               return;
>         }
> 
>         if (qdev->link_config & CFG_JUMBO_FRAME_SIZE &&
> @@ -1135,14 +1136,9 @@ void qlge_mpi_port_cfg_work(struct work_struct *work)
>         if (status) {
>                 netif_err(qdev, drv, qdev->ndev,
>                           "Bug: Failed to set port config data.\n");
> -               goto err;
> +               qlge_queue_fw_error(qdev);
> +               goto end;
>         }
> -end:
> -       clear_bit(QL_PORT_CFG, &qdev->flags);
> -       return;
> -err:
> -       qlge_queue_fw_error(qdev);
> -       goto end;
>  }
> 
>  /* Process an inter-device request.  This is issues by
> -- 
> 2.34.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot