From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/10] staging: r8188eu: clean up private ioctls
Date: Tue, 28 Dec 2021 17:14:02 +0100 [thread overview]
Message-ID: <Ycs3yiJMSWSeehJS@kroah.com> (raw)
In-Reply-To: <20211226212535.197989-1-martin@kaiser.cx>
On Sun, Dec 26, 2021 at 10:25:25PM +0100, Martin Kaiser wrote:
> Clean up the definitions of private ioctls.
> (Maybe it would make more sense to remove them completely?)
If none of them are really "standard", then yes, they should be removed.
At the very least, the correct macros should be used for the remaining
ones.
I'll go queue this up now, thanks!
greg k-h
prev parent reply other threads:[~2021-12-28 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 21:25 [PATCH 00/10] staging: r8188eu: clean up private ioctls Martin Kaiser
2021-12-26 21:25 ` [PATCH 01/10] staging: r8188eu: remove unused rtw_private_args entries Martin Kaiser
2021-12-26 21:25 ` [PATCH 02/10] staging: r8188eu: remove the private ioctl "get sensitivity" Martin Kaiser
2021-12-26 21:25 ` [PATCH 03/10] staging: r8188eu: remove the private drvext_hdl ioctl Martin Kaiser
2021-12-26 21:25 ` [PATCH 04/10] staging: r8188eu: remove the private ioctl "wps_prob_req_ie" Martin Kaiser
2021-12-26 21:25 ` [PATCH 05/10] staging: r8188eu: remove private ioctls that return -1 Martin Kaiser
2021-12-26 21:25 ` [PATCH 06/10] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie" Martin Kaiser
2021-12-26 21:25 ` [PATCH 07/10] staging: r8188eu: remove the private ioctl "tdls_get" Martin Kaiser
2021-12-26 21:25 ` [PATCH 08/10] staging: r8188eu: remove the private ioctl "tdls" Martin Kaiser
2021-12-26 21:25 ` [PATCH 09/10] staging: r8188eu: remove the private "test" ioctl Martin Kaiser
2022-01-06 8:52 ` Dan Carpenter
2021-12-26 21:25 ` [PATCH 10/10] staging: r8188eu: remove unused prototype Martin Kaiser
2021-12-28 16:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ycs3yiJMSWSeehJS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).