From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049E2173 for ; Thu, 6 Jan 2022 14:14:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 366EBC36AE0; Thu, 6 Jan 2022 14:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641478476; bh=slmfr7V9LUKvIHn0GZI1NJ4IhCLh4V1HhpAF4FS8DR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vZHpgAydIbN26uTloIMdOlFTa1huYlZu6ehyfM6eQrSl10qbeCtHktJawpllz6xt3 uM1dGPZ3LxijZjPLKiWi3CfEVciJ1Jhasme2QReCliHNO5EcAa+SThBPSum85n9Nfu 7jHxSkTY/EmnHJMrNz5EqIQSwva1thwiuDV6gllg= Date: Thu, 6 Jan 2022 15:14:34 +0100 From: Greg Kroah-Hartman To: Alberto Merciai Cc: linuxfancy@googlegroups.com, Larry Finger , Phillip Potter , Michael Straube , Martin Kaiser , "Fabio M. De Francesco" , Nathan Chancellor , Dan Carpenter , Saurav Girepunje , Ivan Safonov , Yang Li , Christophe JAILLET , Zameer Manji , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/56] staging: r8188eu: remove dead macro ClearToDs Message-ID: References: <20220103190326.363960-1-alb3rt0.m3rciai@gmail.com> <20220103190326.363960-4-alb3rt0.m3rciai@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220103190326.363960-4-alb3rt0.m3rciai@gmail.com> On Mon, Jan 03, 2022 at 08:01:38PM +0100, Alberto Merciai wrote: > Remove dead macro ClearToDs. "dead"? Was it ever alive? I think you mean to write something like: The #define ClearToDs() is not used anywhere in the r8188eu driver, so it can be safely removed. right? thanks, greg k-h