From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF53173 for ; Wed, 26 Jan 2022 00:58:18 +0000 (UTC) Received: by mail-wm1-f42.google.com with SMTP id q141-20020a1ca793000000b00347b48dfb53so3144435wme.0 for ; Tue, 25 Jan 2022 16:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F1ajyeCYIjo/oOGZ58msEWT7W8A+h5mfhGo1MjpnYCc=; b=tEQdphlxe+odqnIzx6L/54adIDb7Y88J3cFAPyU4CBb6Mn2JbQLTRU8X2AZphdzgXa O3WRyH5vc9hXD26sW4ciwRuy4LGKg+od+MHkWbNnR/ArxQiz9pNX4+/448mPIOtP4cpN Y/xHpuuQ9jSgkIoV79kUb2oIoXRn+IaZIXYiCFY40CRt+bhQYl1Cwqwc34B2tHOhuPsH /PDzikeC4QLWmD1kIb612oOppfKhGz0a5qvBKsaitoJxyiK4bqAkr7suPUc2f/6MDJJh BKLtzcSEIUUouJ+CvXOa7Frymd5xD0/yNUx0Ut4qWzkm4sYwqGOwnoUNiqrYvx77EhoT XbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F1ajyeCYIjo/oOGZ58msEWT7W8A+h5mfhGo1MjpnYCc=; b=z0EOkK8m061IXpEp2h55KE0YZpUfK3PxOz6009YiWUg5KbysGExBYsvw0XnsA3ke4Q NeVXirfj/Z2QdovHYNiBI3jUupDgsRvkWpff4VwE2F5X9fR2hn2RIbvbdfrRSkPjJt8z kQKeUTDbBEIKs4WI7PuiTTPMcVLNsZwaJkggYu8dfWGyOxP/W8dquDF8uPtHgcBjfOzr u61Jxey0SnKA4nwUjXIvuZNaU9E+GXUJR5XOfnOCUgQ4syFdvIPTpe5C24CGVfwNr8qA t3MVqp47TLyyIn0fLQzEmlSYr1QMpfV3f8Yix3FcpqhEXFifgEmBoqWIyEzfyY6LYOQB LwQQ== X-Gm-Message-State: AOAM533aLiL5aduJAP7Bl191ImA5PMfUrF2D/8PDlm8SualQe5Ysvgmk 8Mr7Ak3q3ndmjBb692czvDV9Bg== X-Google-Smtp-Source: ABdhPJyM8U8iNqmQorj9ATdc/xVqC/YmwCvm7jdqJHdvBtXdXBQEFydhD/ABDzpLONM88tAmhdTabA== X-Received: by 2002:a05:600c:1f15:: with SMTP id bd21mr5001978wmb.145.1643158697122; Tue, 25 Jan 2022 16:58:17 -0800 (PST) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id k12sm17847963wrd.98.2022.01.25.16.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 16:58:14 -0800 (PST) Date: Wed, 26 Jan 2022 00:58:12 +0000 From: Phillip Potter To: Pavel Skripkin Cc: dan.carpenter@oracle.com, Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] staging: r8188eu: remove smaller sets of DBG_88E calls from os_dep dir Message-ID: References: <20220124224415.831-1-phil@philpotter.co.uk> <20220124224415.831-6-phil@philpotter.co.uk> <67ddc4d7-e19f-7c9d-a4b7-4eb555830ea1@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67ddc4d7-e19f-7c9d-a4b7-4eb555830ea1@gmail.com> On Tue, Jan 25, 2022 at 03:48:32PM +0300, Pavel Skripkin wrote: > Hi Phillip, > > On 1/25/22 01:44, Phillip Potter wrote: > > Remove all DBG_88E calls from the os_dep directory, other than those in > > os_dep/ioctl_linux.c, as this contains almost 200 on its own so will be > > done in a separate patch for ease of review. These calls do not conform > > to kernel coding standards and are superfluous. Also restructure where > > appropriate to remove no longer needed code left behind by removal of > > these calls. This will allow the eventual removal of the DBG_88E macro > > itself. > > > > Signed-off-by: Phillip Potter > > --- > > [code snip] > > > - /* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto > > - * suspend influence */ > > - if (usb_autopm_get_interface(pusb_intf) < 0) > > - DBG_88E("can't get autopm:\n"); > > - > > Didn't you make a function change here? I didn't test and also didn't find > any mentions of tests in cover letter. > > I am asking just to be sure you done it not by accident :) > > > > > > With regards, > Pavel Skripkin Hi Pavel, Thank you for this and your other feedback, really appreciate it :-) So I mistakenly took this out, you're quite right - will fix in next series. Regards, Phil