From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 171AA2CA8 for ; Wed, 26 Jan 2022 13:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643202244; x=1674738244; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mSnFOYWb2NTAiZJ6gl/F22Fq/rOFI1cKTn49lNqjzw4=; b=MGFdU2KsEa2dTca1z3pCV6qBPAOhNPamSEYoBAeUCk2sMWcnXwE4HkeP xjEhG6ZytrbOivd6jl/8TSJp/O47+UIHyQylOGHoYVPOVawzy0eOZpaXT Jh34UgK8npz1O51JHjYMuchx79wdttE+Qbi0KcYl+u6KPXxF61AR8jqZm Br4XwA4wi3Gzwdzpjebj7vfnp/F4EHN7y9DrkefTWiueqrnfcUKOXJa5l eCzoGGfmWLksw03LmhPHc+TBpTAlnCRCD7kNwUYkORst0YOjsbVG9YWsa W/5B/x071lJjreNDttoC60B8maQ4Nod9Xoa/61I+wYb0QL0eVmqWgNbo9 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="244142423" X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="244142423" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 05:03:50 -0800 X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="617957353" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 05:03:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nChwe-00EbPb-NL; Wed, 26 Jan 2022 15:02:40 +0200 Date: Wed, 26 Jan 2022 15:02:40 +0200 From: Andy Shevchenko To: Joe Perches Cc: Greg Kroah-Hartman , Phillip Potter , Lee Jones , Heiner Kallweit , Carlis , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Michael Hennerich , Helge Deller , Andy Shevchenko Subject: Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' Message-ID: References: <20220125202118.63362-1-andriy.shevchenko@linux.intel.com> <20220125202118.63362-5-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Jan 26, 2022 at 12:54:13AM -0800, Joe Perches wrote: > On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > > for the sake of deduplication. > [] > > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig > [] > > @@ -10,87 +10,75 @@ menuconfig FB_TFT > > select FB_DEFERRED_IO > > select FB_BACKLIGHT > > > > +if FB_TFT > > + > [] > > config FB_TFT_PCD8544 > > tristate "FB driver for the PCD8544 LCD Controller" > > - depends on FB_TFT > > help > > Generic Framebuffer support for PCD8544 > > > > @@ -108,62 +96,52 @@ config FB_TFT_S6D02A1 > > Looks like you missed a couple. Thanks! I'll incorporate it, if the series has a continuation. -- With Best Regards, Andy Shevchenko