From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: realwakka@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: pi433: add debugfs interface
Date: Sat, 29 Jan 2022 16:35:09 +1300 [thread overview]
Message-ID: <YfS17W10UTAKn3dc@mail.google.com> (raw)
In-Reply-To: <YfE4d4UY1yIVvapC@kroah.com>
On Wed, Jan 26, 2022 at 01:03:03PM +0100, Greg KH wrote:
>
> Breaks the build:
>
> drivers/staging/pi433/pi433_if.c:1166:25: error: initialization of ‘int (*)(struct inode *, struct file *)’ from incompatible pointer type ‘ssize_t (*)(struct inode *, struct file *)’ {aka ‘long int (*)(struct inode *, struct file *)’} [-Werror=incompatible-pointer-types]
> 1166 | .open = pi433_debugfs_regs_open,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
>
My apologies, I will be more careful next time. I must have missed
something out on my module-specific makefile.
I will incorporate the changes that Dan Carpenter suggested and submit a
new version of this patch shortly.
thanks,
Paulo A.
next prev parent reply other threads:[~2022-01-29 3:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 7:38 [PATCH 0/2] staging: pi433: add debugfs interface Paulo Miguel Almeida
2022-01-23 7:39 ` [PATCH 1/2] staging: pi433: add missing register contants Paulo Miguel Almeida
2022-01-23 7:40 ` [PATCH 2/2] staging: pi433: add debugfs interface Paulo Miguel Almeida
2022-01-23 11:20 ` Greg KH
2022-01-24 4:14 ` Paulo Miguel Almeida
2022-01-24 4:25 ` [PATCH v2 0/2] " Paulo Miguel Almeida
2022-01-24 4:26 ` [PATCH v2 1/2] staging: pi433: add missing register contants Paulo Miguel Almeida
2022-01-24 4:27 ` [PATCH v2 2/2] staging: pi433: add debugfs interface Paulo Miguel Almeida
2022-01-26 12:03 ` Greg KH
2022-01-29 3:35 ` Paulo Miguel Almeida [this message]
2022-01-26 13:21 ` Dan Carpenter
2022-01-29 3:30 ` Paulo Miguel Almeida
2022-01-30 2:57 ` [PATCH v3] " Paulo Miguel Almeida
2022-01-31 13:45 ` Dan Carpenter
2022-01-31 16:45 ` Greg KH
2022-01-31 19:37 ` Paulo Miguel Almeida
2022-02-04 5:06 ` [PATCH v4] " Paulo Miguel Almeida
2022-02-04 8:04 ` [PATCH v5] " Paulo Miguel Almeida
2022-02-04 9:02 ` Dan Carpenter
2022-02-04 8:55 ` [PATCH v4] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfS17W10UTAKn3dc@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).