From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, realwakka@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: remove unnecessary new line escape sequence characters
Date: Tue, 1 Feb 2022 08:30:32 +1300 [thread overview]
Message-ID: <Yfg42KS3sQ8PZmo1@mail.google.com> (raw)
In-Reply-To: <20220131104020.GI1951@kadam>
On Mon, Jan 31, 2022 at 01:40:20PM +0300, Dan Carpenter wrote:
> > if (device->irq_state[DIO0] == DIO_PACKET_SENT) {
> > device->free_in_fifo = FIFO_SIZE;
> > - dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
> > + dev_dbg(device->dev, "DIO0 irq: Packet sent");
>
> Both the old and new code will do the same thing. You are correct.
> However in terms of style, I believe the preference is to add a newline.
>
> I don't remember the reasoning behind this. But a lot of these style
> rules are just decided by consensus. If you do a
> `git grep -w dev_dbg | grep \;$` then it is 12391 places that add a
> new line and 622 which don't. Adding a newline is the clear winner.
>
it makes sense. I will send a different patch adding the newline escapes
instead.
Thanks heaps!
Paulo Almeida
prev parent reply other threads:[~2022-01-31 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 6:18 [PATCH] staging: pi433: remove unnecessary new line escape sequence characters Paulo Miguel Almeida
2022-01-31 10:40 ` Dan Carpenter
2022-01-31 19:30 ` Paulo Miguel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfg42KS3sQ8PZmo1@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).