From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CC6163 for ; Sun, 20 Feb 2022 08:30:04 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DF03425B; Sun, 20 Feb 2022 09:30:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645345802; bh=lZtw0Ai5I9RpBLtQIoRUoY736iPcQhObsm0HWhcuZCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ww9m5Jgxy3ZcSyQmyp5evBuSHXP5JK/a1PTgKz05RKgqJi5/7nbjGMG6IZGAtdhYa BQaDtIfu8iOKljFE9WKTzhiYN86aIE+YaDzS+NUkDCRR/DLkBoFrBesRz6KX2BSV/z qAHa+A5U8uM/njzrM/dhj15zYteE7aQ+sSiSFh8w= Date: Sun, 20 Feb 2022 10:29:52 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, martin.kepplinger@puri.sm, rmfrfs@gmail.com, xavier.roumegue@oss.nxp.com, alexander.stein@ew.tq-group.com, dorota.czaplejewicz@puri.sm, kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/7] media: imx: imx-mipi-csis: Add BGR888 Message-ID: References: <20220218183421.583874-1-jacopo@jmondi.org> <20220218183421.583874-7-jacopo@jmondi.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220218183421.583874-7-jacopo@jmondi.org> Hi Jacopo, Thank you for the patch. On Fri, Feb 18, 2022 at 07:34:20PM +0100, Jacopo Mondi wrote: > Add support for the BGR888_1X24 image formats. > > The BGR888 format definition matches how pixel components are sent on > the wire according to the CSI-2 specification. A bit more information that you may want to capture, for readers who are not familiar with this: No existing media bus codes describe exactly the way data is transferred on the CSI-2 bus. This is not a new issue, the CSI-2 YUV422 8-bit format is described by MEDIA_BUS_FMT_UYVY8_1X16 which is an arbitrary convention and not an exact match. Use the MEDIA_BUS_FMT_BGR888_1X24 to follow the same convention, based on the order in which bits are transmitted over the CSI-2 bus. > Signed-off-by: Jacopo Mondi > --- > drivers/media/platform/imx/imx-mipi-csis.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > index c7a771e3fdf3..fdf133f81c5b 100644 > --- a/drivers/media/platform/imx/imx-mipi-csis.c > +++ b/drivers/media/platform/imx/imx-mipi-csis.c > @@ -366,6 +366,11 @@ static const struct csis_pix_format mipi_csis_formats[] = { > .data_type = MIPI_CSI2_DATA_TYPE_RGB565, > .width = 16, > }, > + { }, { Reviewed-by: Laurent Pinchart > + .code = MEDIA_BUS_FMT_BGR888_1X24, > + .data_type = MIPI_CSI2_DATA_TYPE_RGB888, > + .width = 24, > + }, > /* RAW (Bayer and greyscale) formats. */ > { > .code = MEDIA_BUS_FMT_SBGGR8_1X8, -- Regards, Laurent Pinchart