From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: vt6656: Add comment and change macro to function
Date: Mon, 21 Feb 2022 18:15:18 +0100 [thread overview]
Message-ID: <YhPIpvz4X9BrR3J6@kroah.com> (raw)
In-Reply-To: <3eb14cfaa3f97695bd4db0dd75ac78408c557821.1645386791.git.philipp.g.hortmann@gmail.com>
On Sun, Feb 20, 2022 at 09:30:36PM +0100, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warnings like:
> - CHECK: spinlock_t definition without comment
> - CHECK: Avoid CamelCase: <uVar>
> - CHECK: Macro argument reuse 'uVar' - possible side-effects?
That is 3 different things and so, should be 3 different patches.
Please break patches up into "one patch per logical change".
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-21 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 20:30 [PATCH 0/3] staging: vt6656: Fix CamelCase, add comments, change macro to function Philipp Hortmann
2022-02-20 20:30 ` [PATCH 1/3] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c Philipp Hortmann
2022-02-21 12:27 ` Dan Carpenter
2022-02-20 20:30 ` [PATCH 2/3] staging: vt6656: Add comment and change macro to function Philipp Hortmann
2022-02-21 12:33 ` Dan Carpenter
2022-02-21 17:15 ` Greg Kroah-Hartman [this message]
2022-02-20 20:30 ` [PATCH 3/3] staging: vt6656: Remove ftrace-like logging and unnecessary line breaks Philipp Hortmann
2022-02-21 12:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhPIpvz4X9BrR3J6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).