From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC65C1855 for ; Mon, 14 Mar 2022 11:33:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C0F6C340EC; Mon, 14 Mar 2022 11:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647257627; bh=WnA80cH9bCfifQAruhmVw0SF3GOH8r0waE1k9+hp16M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NtN9qLvGrdCVps1JMlMK+p3Zl6l/JM8B2TKNo/eHGwlfB+zl2jVvb9xhyjedeLN7K ZOwkP8PInd4Q1R6cYhpxvJmagFxptOMCqBWTjDuwzwu6w1FxGzQ41rW7PPGOy8cTGU /UUqeoFQ/ONH3p/P7ESxslIQpDebHm/19u/RmBaE= Date: Mon, 14 Mar 2022 12:33:42 +0100 From: Greg Kroah-Hartman To: shaikh kamaluddin Cc: Pavel Skripkin , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script. Message-ID: References: <20220312204128.3942-1-shaikhkamal2012@gmail.com> <303ed0c8-8e2c-51a4-a4da-be973a25cdec@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 14, 2022 at 04:55:55PM +0530, shaikh kamaluddin wrote: > On 3/13/2022 3:13 AM, Pavel Skripkin wrote: > > Hi Shaikh, > > > > On 3/12/22 23:41, shaikh kamal wrote: > > > Signed-off-by: shaikh kamal > > > --- > > >   drivers/staging/android/ashmem.c | 2 +- > > >   1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/android/ashmem.c > > > b/drivers/staging/android/ashmem.c > > > index ddbde3f8430e..4c6b420fbf4d 100644 > > > --- a/drivers/staging/android/ashmem.c > > > +++ b/drivers/staging/android/ashmem.c > > > @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file > > > *file, unsigned long addr, > > >   static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > > >   { > > > -    static struct file_operations vmfile_fops; > > > +    static const struct file_operations vmfile_fops; > > >       struct ashmem_area *asma = file->private_data; > > >       int ret = 0; > > > > Are you sure this patch compiles? vmfile_fops is overrided few lines below > > > > odd checkpatch.pl warning... > > > > > > > > > > With regards, > > Pavel Skripkin > > Thank you,yes vmfile_fops is overrided in below code. > Building the kernel - make -j4, > drivers/staging/android/ashmem.c: In function ‘ashmem_mmap’: > drivers/staging/android/ashmem.c:431:16: error: assignment of read-only > variable ‘vmfile_fops’ > vmfile_fops = *vmfile->f_op; > ^ > drivers/staging/android/ashmem.c:432:21: error: assignment of member ‘mmap’ > in read-only object > vmfile_fops.mmap = ashmem_vmfile_mmap; > ^ > drivers/staging/android/ashmem.c:433:34: error: assignment of member > ‘get_unmapped_area’ in read-only object > vmfile_fops.get_unmapped_area = > ^ > scripts/Makefile.build:288: recipe for target > 'drivers/staging/android/ashmem.o' failed > make[3]: *** [drivers/staging/android/ashmem.o] Error 1 > scripts/Makefile.build:550: recipe for target 'drivers/staging/android' > failed > make[2]: *** [drivers/staging/android] Error 2 > scripts/Makefile.build:550: recipe for target 'drivers/staging' failed > make[1]: *** [drivers/staging] Error 2 > Makefile:1831: recipe for target 'drivers' failed As always, it is expected that when you submit a change to the kernel, at the very least you have test-built it to ensure that it does not break the build. Please remember to do this next time. thanks, greg k-h