From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: r8188eu: some rx cleanups
Date: Mon, 14 Mar 2022 18:30:27 +0100 [thread overview]
Message-ID: <Yi97s4Eu20CVE/Ds@kroah.com> (raw)
In-Reply-To: <20220305185351.1409232-1-martin@kaiser.cx>
On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> Here's another set with simple cleanups in the code for receiving frames.
>
> Martin Kaiser (6):
> staging: r8188eu: remove unnecessary initializations
> staging: r8188eu: remove three unused receive defines
> staging: r8188eu: remove unused function prototype
> staging: r8188eu: make rtl8188e_process_phy_info static
> staging: r8188eu: remove some unused local ieee80211 macros
> staging: r8188eu: remove local BIT macro
>
> drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +---
> .../staging/r8188eu/include/rtl8188e_recv.h | 6 ----
> drivers/staging/r8188eu/include/wifi.h | 34 +------------------
> 3 files changed, 2 insertions(+), 44 deletions(-)
>
> --
> 2.30.2
>
>
This series breaks the build:
drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
I'm going to drop it from my queue now.
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-14 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
2022-03-05 18:53 ` [PATCH 1/6] staging: r8188eu: remove unnecessary initializations Martin Kaiser
2022-03-05 18:53 ` [PATCH 2/6] staging: r8188eu: remove three unused receive defines Martin Kaiser
2022-03-05 18:53 ` [PATCH 3/6] staging: r8188eu: remove unused function prototype Martin Kaiser
2022-03-05 18:53 ` [PATCH 4/6] staging: r8188eu: make rtl8188e_process_phy_info static Martin Kaiser
2022-03-05 18:53 ` [PATCH 5/6] staging: r8188eu: remove some unused local ieee80211 macros Martin Kaiser
2022-03-05 18:53 ` [PATCH 6/6] staging: r8188eu: remove local BIT macro Martin Kaiser
2022-03-14 17:30 ` Greg Kroah-Hartman [this message]
2022-03-15 20:55 ` [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
2022-03-16 6:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi97s4Eu20CVE/Ds@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).