From: Greg KH <gregkh@linuxfoundation.org>
To: 白浩文 <baihaowen@meizu.com>
Cc: "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
"phil@philpotter.co.uk" <phil@philpotter.co.uk>,
"straube.linux@gmail.com" <straube.linux@gmail.com>,
"martin@kaiser.cx" <martin@kaiser.cx>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 答复: [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Date: Mon, 28 Mar 2022 11:12:19 +0200 [thread overview]
Message-ID: <YkF78wyXCaQIwkB2@kroah.com> (raw)
In-Reply-To: <be09d628f09041ac8f2c7bf2e9d5a13d@meizu.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Mar 28, 2022 at 09:07:44AM +0000, 白浩文 wrote:
> Hi, Greg KH
>
> Yes, I think sync rtl8723bs and r8188eu will be better as they have same problem.
>
> commit 067756acdac8e0dd91edf4800e844fcb6e0cc72a
> Author: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> Date: Mon Jul 15 23:16:18 2019 +0530
>
> staging: rtl8723bs: core: Change return type of init_mlme_ext_priv
>
> As init_mlme_ext_priv function always returns SUCCESS , We can change
> return type from int to void.
>
> Fixes below issue identified by coccicheck
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
> variable: "res". Return "_SUCCESS" on line 492
Yes, that would be good.
next prev parent reply other threads:[~2022-03-28 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:43 [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable Haowen Bai
2022-03-28 8:47 ` Greg KH
2022-03-28 9:07 ` 答复: " 白浩文
2022-03-28 9:12 ` Greg KH [this message]
2022-03-29 9:59 ` baihaowen
2022-03-29 11:06 ` [PATCH] " Haowen Bai
2022-03-29 11:09 ` [PATCH V3] " Haowen Bai
2022-03-29 11:28 ` Dan Carpenter
2022-03-30 1:14 ` baihaowen
2022-03-30 1:28 ` [PATCH V4] " Haowen Bai
2022-03-30 7:20 ` Dan Carpenter
2022-03-29 11:26 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkF78wyXCaQIwkB2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=baihaowen@meizu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).