Re: [PATCH v4] staging: rts5208: Convert kmap() to kmap_local_page()

Dan Carpenter
2022-03-30T15:33:21Z

On Wed, Mar 30, 2022 at 04:33:31PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Therefore rtsx_stor_access_xfer_buf() is a function
> where the use of kmap_local_page() in place of kmap() is correctly
> suited.
>
> Convert to kmap_local_page() but, instead of open coding it, use the
> helpers memcpy_to_page() and memcpy_from_page().
>
> Make a minor change to a comment related to scatter-gather.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---

LGTM.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter