From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3BF47E0 for ; Thu, 31 Mar 2022 05:52:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A1ABC340ED; Thu, 31 Mar 2022 05:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648705946; bh=7WIb2O/ijIFwfYmhFi5G0UXBjXEKNalAGXR9f+8HLDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Quq34u06rN6LVE3rAFOT0Arh8ULMBTFH80rwI7D4fV0s1rEYD+3uPGj+nY1VzPosF D8Zc4tr8GeIARMdFQvIBEJt/thD8uHzPqixuUcDkU44RxL6rcm9+5TilWkFKCltC4K LQ/uTlxfQO7yCsDu0VDVID6UUqN0OQdBD7Bd7164= Date: Thu, 31 Mar 2022 07:52:24 +0200 From: Greg KH To: Michael Straube Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/8] staging: r8188eu: remove HW_VAR_RXDMA_AGG_PG_TH from SetHwReg8188EU() Message-ID: References: <20220329202141.7028-1-straube.linux@gmail.com> <20220329202141.7028-6-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329202141.7028-6-straube.linux@gmail.com> On Tue, Mar 29, 2022 at 10:21:38PM +0200, Michael Straube wrote: > The HW_VAR_RXDMA_AGG_PG_TH case in SetHwReg8188EU() just sets a > variable conditionally and then calls rtw_write8(). Set the variable > in the caller and call rtw_write8() directly. Move the functionality > into a new static function to make the code cleaner. Remove the > HW_VAR_RXDMA_AGG_PG_TH case from SetHwReg8188EU(). This is part of the > ongoing effort to get rid of the unwanted hal layer. > > Signed-off-by: Michael Straube > --- > v2: Moved the code into a function and included patch 6/9 of v1. > > drivers/staging/r8188eu/core/rtw_mlme.c | 34 +++++++++++++--------- > drivers/staging/r8188eu/hal/usb_halinit.c | 8 ----- > drivers/staging/r8188eu/include/hal_intf.h | 1 - > 3 files changed, 21 insertions(+), 22 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index f1e1627641cb..086d64542082 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -1787,10 +1787,29 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter) > > } > > +static void rtw_set_threshold(struct adapter *adapter) > +{ > + u8 threshold; > + struct mlme_priv *mlmepriv = &adapter->mlmepriv; > + struct ht_priv *htpriv = &mlmepriv->htpriv; > + > + /* TH = 1 => means that invalidate usb rx aggregation */ > + /* TH = 0 => means that validate usb rx aggregation, use init value. */ > + if (htpriv->ht_option) { > + if (adapter->registrypriv.wifi_spec == 1) > + threshold = 1; > + else > + threshold = USB_RXAGG_PAGE_COUNT; > + > + rtw_write8(adapter, REG_RXDMA_AGG_PG_TH, threshold); > + } else { > + rtw_write8(adapter, REG_RXDMA_AGG_PG_TH, 1); > + } > +} For future cleanups, this function can be made a lot smaller :) thanks, greg k-h