From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bruno Moreira-Guedes <codeagain@codeagain.dev>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
Bruno's Patch Watchbox <patch-reply@codeagain.dev>
Subject: Re: [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig
Date: Wed, 20 Apr 2022 18:43:12 +0200 [thread overview]
Message-ID: <YmA4ILK5Gv/Gdaso@kroah.com> (raw)
In-Reply-To: <20220418233929.zz32dil4u6hbwtqv@AN5Bruno>
On Mon, Apr 18, 2022 at 08:39:29PM -0300, Bruno Moreira-Guedes wrote:
> Please, disregard the following message as there's a typo in the prefix.
>
> On Mon, Apr 18, 2022 at 08:31:09PM -0300, Bruno Moreira-Guedes wrote:
> > The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
> > sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
> > VME_BUS, which is unnoticeable for menuconfig users who aren't be able
> > to select it through this interface without setting the CONFIG_VME_BUS
> > option because it's nested on VME_BUS menu entry.
> ...
> > VME windows in a manner at least semi-compatible with the interface
> > --
> > 2.35.3
> >
>
> It's already sent a new copy with the proper version number. Nothing's
> changed except for the message ID and the v2 typo.
I can't handle 2 v2 of this same commit, our tools get very confused (as
do people.) Would you be able to unwind this if you were in my
position?
Please resubmit a v3 of this series with everything fixed up.
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-20 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:29 [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Bruno Moreira-Guedes
2022-04-18 23:30 ` [PATCH v3 1/3] staging: vme: Move vme_user to staging KConfig Bruno Moreira-Guedes
2022-04-18 23:31 ` [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig Bruno Moreira-Guedes
2022-04-18 23:39 ` Bruno Moreira-Guedes
2022-04-20 16:43 ` Greg Kroah-Hartman [this message]
2022-04-20 21:12 ` Bruno Moreira-Guedes
2022-04-21 6:07 ` Greg Kroah-Hartman
2022-04-18 23:31 ` [PATCH v3 3/3] staging: vme: Move 'vme/devices' to 'vme_user/' Bruno Moreira-Guedes
2022-04-18 23:35 ` [PATCH v3 2/3] staging: vme: Add VME_BUS dependency to Kconfig Bruno Moreira-Guedes
2022-04-20 16:43 ` [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Greg Kroah-Hartman
2022-04-21 19:16 ` Martyn Welch
2022-04-22 6:39 ` Greg Kroah-Hartman
2022-04-27 12:18 ` Bruno Moreira-Guedes
2022-04-27 12:31 ` Greg Kroah-Hartman
2022-04-27 12:41 ` Bruno Moreira-Guedes
2022-04-27 13:10 ` Greg Kroah-Hartman
2022-04-27 16:16 ` Alison Schofield
2022-04-20 22:35 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmA4ILK5Gv/Gdaso@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=codeagain@codeagain.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=patch-reply@codeagain.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox