From: Greg KH <gregkh@linuxfoundation.org>
To: Jaehee Park <jhpark1013@gmail.com>
Cc: Alex Elder <elder@ieee.org>,
johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 2/2] staging: greybus: remove empty callback function
Date: Wed, 20 Apr 2022 17:15:34 +0200 [thread overview]
Message-ID: <YmAjliv4DdTY+JvZ@kroah.com> (raw)
In-Reply-To: <20220414200932.GA4147124@jaehee-ThinkPad-X1-Extreme>
On Thu, Apr 14, 2022 at 04:09:32PM -0400, Jaehee Park wrote:
> On Wed, Apr 13, 2022 at 07:48:03AM -0500, Alex Elder wrote:
> > On 4/12/22 11:38 PM, Jaehee Park wrote:
> > > Remove the optional remove callback for the soc_codec_dev_gbaudio
> > > structure. The only place it is referenced is
> > > snd_soc_component_remove() which is only called if the sound_component
> > > pointer is non-null. The null function pointers here can be optionally
> > > ommitted. When a sound component is registered this way, the remove
> > > callback is optional. We can safely remove the whole gbcodec_remove
> > > function, which used to be an empty function with a void return type.
> >
> > Now I think your description is a little long... But that's OK.
> >
> > This looks good to me. Thank you for responding to all our
> > feedback.
> >
> > Reviewed-by: Alex Elder <elder@linaro.org>
>
> hi Greg, I saw that this was past on to staging-next already. Is it too
> late to add Alex to the reviewed by?
Yes, sorry.
prev parent reply other threads:[~2022-04-20 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 4:38 [PATCH v3 0/2] staging: greybus: fix warnings reported by checkpatch Jaehee Park
2022-04-13 4:38 ` [PATCH v3 1/2] staging: greybus: correct typo in comment Jaehee Park
2022-04-13 4:38 ` [PATCH v3 2/2] staging: greybus: remove empty callback function Jaehee Park
2022-04-13 5:44 ` Dan Carpenter
2022-04-13 12:48 ` Alex Elder
2022-04-14 20:09 ` Jaehee Park
2022-04-20 15:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmAjliv4DdTY+JvZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jhpark1013@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox