From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from camel.birch.relay.mailchannels.net (camel.birch.relay.mailchannels.net [23.83.209.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E46A1867 for ; Wed, 20 Apr 2022 17:20:28 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 22C07760EF8; Wed, 20 Apr 2022 17:20:18 +0000 (UTC) Received: from pdx1-sub0-mail-a217.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9DA27761E06; Wed, 20 Apr 2022 17:20:17 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1650475217; a=rsa-sha256; cv=none; b=s0RJWcnTBaikUpP2bdENAkxCaxueJhakQv3bdyStQQH4WxzxQgy1N1ckoapMzJ36h9gniC VELrp99uSpJPE25wRxLp2zYpnft31WGJFqyA8YRjxxsjEjezfXIX4YvZvy915Q8V5S+0z3 1cRlQw6VTcRi2MIX+Oi+P8IExrazSd+nCyBkTZY9YJlS+1lK4d0KJaB324AEREAGexzswR 4MtXdEOdS6MP2mSE5VOcR4UPQ/w7/2G9d96vN79vxaMg+hfsg11j8wm2h6sNCWDo+CwA3v hm5Ir4beM0zkxov3yCwlsW0OkHah55iM5GE+iohwiFkDckaetnTsvokb7kA77A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1650475217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cdf9+k2VtzTYEJ/Pkh71vf3BfUPmRtgtQ3uFbGpaeMk=; b=8Coi8OH7XLRzpsgWiWi/u0Jl54NuXBOaTKKoRvX7VWkNi3wVoFKnNxQP4lnK97zg6mcqQ/ DpQjIz+wa04WRxVSh8uma4IXXtKiYumHZG/Ms2Bmi9puMhAMenHkFKtML7a2dnRmiiQ+rF Jum3dJBRbyo/2jmis6++J2CzwF7m11NNJkDpw46tSBZrmKyxbrvTf44PobxxDGQpY7gH6Z SERbPog6+69HfO8nkg/neVuCjOpA7Xn9a87Wuc7zjThI3pmxORvwElKUuVU1/RKtJ0n+kN 3KmJObns+VzaL80C1hY5D6wrYhxtuYELnCKR/hIgnQQzuLaOAtAjlGKEz8GxVQ== ARC-Authentication-Results: i=1; rspamd-58ff8d7479-2jpfw; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from pdx1-sub0-mail-a217.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.115.45.25 (trex/6.7.1); Wed, 20 Apr 2022 17:20:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Obese-Sponge: 1fefb2c312ac0071_1650475217954_481480763 X-MC-Loop-Signature: 1650475217954:3309040606 X-MC-Ingress-Time: 1650475217954 Received: from fedora (unknown [69.12.38.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a217.dreamhost.com (Postfix) with ESMTPSA id 4Kk6r04fgMz1L; Wed, 20 Apr 2022 10:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1650475217; bh=cdf9+k2VtzTYEJ/Pkh71vf3BfUPmRtgtQ3uFbGpaeMk=; h=Date:From:To:Cc:Subject:Content-Type:Content-Transfer-Encoding; b=mqNGUQzXCPkxLoMRh7xClxiLUkEU5/luuPaKDg9MNoqjy2CLqMQmGSPDhRUr6vxnC iyyfk78aapwEFfoRMRuXumSB5nGnhn3z10vSJChkoJv3X4NSVLtN8iuT8uvhjjL2ie C5GdMLBQGgIU3LTWvQtPx0kdF15SayU584FfBTTupGCzCnnS9fwgYuwBjSt+5HfXYz TUC9lZmN/N/GGEWZNB2v2ra2CueFGrzoAJKRGhmuFh+uWe+dqPoOqufZ1dWuKMn6cq MU1FDoNbXBTegPkU0kYhpAZNRwSjMyFsZ7uWPZsTUcqWJUGPf4UNsTABbv71546Cks 0oXKM36lLudQQ== Date: Wed, 20 Apr 2022 13:20:14 -0400 From: Ian Cowan To: Javier Martinez Canillas Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] Staging: fbtft: Fix style problem in header Message-ID: References: <20220419192128.445023-1-ian@linux.cowan.aero> <20220420064711.xuhuyhtgcrs3avhk@pengutronix.de> <20220420143608.yuxleiffs234dfog@pengutronix.de> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Apr 20, 2022 at 05:47:49PM +0200, Javier Martinez Canillas wrote: > On 4/20/22 16:36, Uwe Kleine-König wrote: > You are just changing a header file though, did you also enable one of the > fbtft drivers as a module to see if those build? But as said, by looking at > the code it seems that should build correctly. Not loading the driver was the issue. Thanks for helping me get it fixed! --- Ian Cowan