From: Greg KH <gregkh@linuxfoundation.org>
To: "Yaşar Arabacı" <yasar11732@gmail.com>
Cc: paulo.miguel.almeida.rodenas@gmail.com, dan.carpenter@oracle.com,
alexandre.belloni@bootlin.com, realwakka@gmail.com,
u.kleine-koenig@pengutronix.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: pi433: Don't use ioctl for per-client configuration
Date: Sun, 15 May 2022 12:55:46 +0200 [thread overview]
Message-ID: <YoDcMmcnbPjk4uuV@kroah.com> (raw)
In-Reply-To: <20220515104711.94567-1-yasar11732@gmail.com>
On Sun, May 15, 2022 at 01:47:11PM +0300, Yaşar Arabacı wrote:
> Currently this driver uses ioctl for reading/writing per-device and
> per-client configuration. Per-client configuration can be handled by
> usespace and sent to driver with each write() call. Doing so does not
> introduce extra overhead because we copy tx config to fifo for each
> transmit anyway. This way, we don't have to introduce new ioctl's.
Wait, you just changed the user api of the write/read call to the
driver? That's dangerous, especially:
> This has not been tested as I don't have access to hardware.
That's not good. You need to figure out what userspace tool(s) use this
api and ensure that you did not just break them for no good reason.
thanks,
greg k-h
next prev parent reply other threads:[~2022-05-15 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 10:47 [PATCH] Staging: pi433: Don't use ioctl for per-client configuration Yaşar Arabacı
2022-05-15 10:54 ` Greg KH
2022-05-15 10:55 ` Greg KH [this message]
2022-05-16 7:33 ` Dan Carpenter
2022-05-16 17:23 ` Yaşar Arabacı
2022-05-16 11:23 ` kernel test robot
2022-05-16 15:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoDcMmcnbPjk4uuV@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paulo.miguel.almeida.rodenas@gmail.com \
--cc=realwakka@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yasar11732@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox