* [PATCH] staging: rts5208: spi.c: prefer ftrace
@ 2022-05-17 19:28 Srivathsan Sivakumar
2022-05-19 15:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Srivathsan Sivakumar @ 2022-05-17 19:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel
fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Srivathsan Sivakumar <sri.skumar05@gmail.com>
---
drivers/staging/rts5208/spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
index f1e9e80044ed..0d2d065508d3 100644
--- a/drivers/staging/rts5208/spi.c
+++ b/drivers/staging/rts5208/spi.c
@@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
spi->write_en = srb->cmnd[6];
- dev_dbg(rtsx_dev(chip), "%s: ", __func__);
dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rts5208: spi.c: prefer ftrace
2022-05-17 19:28 [PATCH] staging: rts5208: spi.c: prefer ftrace Srivathsan Sivakumar
@ 2022-05-19 15:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-05-19 15:36 UTC (permalink / raw)
To: Srivathsan Sivakumar; +Cc: linux-staging, linux-kernel
On Tue, May 17, 2022 at 03:28:11PM -0400, Srivathsan Sivakumar wrote:
> fix the following checkpatch.pl warning:
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
>
> Signed-off-by: Srivathsan Sivakumar <sri.skumar05@gmail.com>
> ---
> drivers/staging/rts5208/spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
> index f1e9e80044ed..0d2d065508d3 100644
> --- a/drivers/staging/rts5208/spi.c
> +++ b/drivers/staging/rts5208/spi.c
> @@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
> spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
> spi->write_en = srb->cmnd[6];
>
> - dev_dbg(rtsx_dev(chip), "%s: ", __func__);
> dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
> dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
> dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);
All three of the remaining ones should be on one line, right?
Can you fix this up and do that all at once?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-17 19:28 [PATCH] staging: rts5208: spi.c: prefer ftrace Srivathsan Sivakumar
2022-05-19 15:36 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).