From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59D0E23A0 for ; Mon, 6 Jun 2022 06:10:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0986C385A9; Mon, 6 Jun 2022 06:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654495857; bh=4/5NEymG1UDzDdn8M6SuObew1HoxRYtX4PVktnUJ7q8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gs7sCzMXF8xrbv1j5rRHz88GLBQd3ocAchiZl/tVtiPgpVLQPa1gkZYH1JWRpiYwb 7Z0iPN3RTLtZAXFbIM9upoFCqkFU5Ekkqkd1ia4W/AwHaj4XFkaD5NqV6gHUgHgiBu Bt336NfMDqZCUP5TsSXPq5qkJ3WF2MSaICOPb6Tc= Date: Mon, 6 Jun 2022 08:10:54 +0200 From: Greg KH To: Larry Finger Cc: Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v3 0/2] Fix some compile warnings in v5.18+ Message-ID: References: <20220531013103.2175-1-Larry.Finger@lwfinger.net> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 31, 2022 at 12:16:58PM -0500, Larry Finger wrote: > On 5/31/22 01:40, Phillip Potter wrote: > > > > Hi Larry, > > > > Both patches look good to me, however I've already submitted a patch 10 > > days ago that does exactly what your rtw_xmit.c patch does, in > > addition to fixing the changed error handling semantics for the relevant > > function (in f94b47c6bde6) which broke the driver. > > Phil, > > Sorry I missed your patch. I have been really busy the past month on another > problem, and I was not paying much attention to r8188eu. > > When I built a mainline kernel in the middle of the merge from 5.18 to 5.19, > those two warnings stood out. > > Your patch should be ahead of mine in Greg's queue, thus mine should fail, > and I will get the "does not apply" message. At that time, I will send the > other patch. As both of us missed the 5.19 merge, the build warnings will > persist until 5.20, but no harm. I've taken Phillip's patch, and your second patch here, both for 5.19-final, so all should be good now. thanks, greg k-h