From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECFB17E for ; Sun, 5 Jun 2022 14:14:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F6CDC385A5; Sun, 5 Jun 2022 14:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654438483; bh=DnxN5ambVi3dI6+cdjSLkE5eBkMXsX56J4bxLEa/gCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CtsNbvCnjWY+NytgmtVZi80XbCPc6SLOwZgOy/EMSsv9k3e6KHKxUrEA2CfKlNlSD 5JsaI6cN/G0KyQDPXUB7urdRUXspWneWagpsrk39MeyM/oo6B4c9MloxXNfyf27HXs tTLB5zb3QXlQ7rKmLhOta0b9+B9D1Y3IHwULUSu4= Date: Sun, 5 Jun 2022 16:14:40 +0200 From: Greg KH To: Andrea Paris Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixed 3 warnings about missing blank line after declaration Message-ID: References: <20220605135716.GA11092@student.ethz.ch> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220605135716.GA11092@student.ethz.ch> On Sun, Jun 05, 2022 at 03:57:16PM +0200, Andrea Paris wrote: > Fixed three checkpatch.pl warnings about missing blank lines after > declaration > > Signed-off-by: Andrea Paris > --- > drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c > index 06523d91939a..92d5e4534087 100644 > --- a/drivers/staging/r8188eu/core/rtw_cmd.c > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c > @@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv) > > while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { > void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue); > + > if (c2h && c2h != (void *)pevtpriv) > kfree(c2h); > } > @@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid, > /* prepare ssid list */ > if (ssid) { > int i; > + > for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) { > if (ssid[i].SsidLength) { > memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid)); > @@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid, > /* prepare channel list */ > if (ch) { > int i; > + > for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) { > if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) { > memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel)); > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot