Re: [greybus-dev] Re: [PATCH v2] staging: greybus: audio: fix loop cursor use after iteration

Johan Hovold
2022-06-10T08:17:03Z

On Fri, Jun 10, 2022 at 11:06:27AM +0300, Dan Carpenter wrote:
> On Fri, Jun 10, 2022 at 10:00:03AM +0200, Johan Hovold wrote:
> > > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio modules")
> > > Cc: stable@vger.kernel.org
> > > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Reviewed-by: Johan Hovold <johan@kernel.org>
> > > Signed-off-by: Jared Kangas <kangas.jd@gmail.com>
> > > ---
> > >
> > > Changes since v1:
> > > * Removed safe list iteration as suggested by Johan Hovold <johan@kernel.org>
> > > * Updated patch changelog to explain the list iteration change
> > > * Added tags to changelog based on feedback (Cc:, Fixes:, Reviewed-by:)
> >
> > Apparently Greg applied this to staging-next before we had a change to
> > look at it. You should have received a notification from Greg when he
> > did so.
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=80c968a04a381dc0e690960c60ffd6b6aee7e157
> >
> > It seems unlikely that this would cause any issues in real life, but
> > there's still a chance it will be picked up by the stable team despite
> > the lack of a CC stable tag.
>
> If you want you can always email the stable team to pick up the patch.

Yes, of course. But it will be months before this fix hits mainline and
I probably won't remember to do so then.

I'm pretty sure Sasha's autosel tool will pick it up anyway, though.

Johan