* [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address
@ 2022-07-01 9:40 Huang Zetao
2022-07-01 9:49 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Huang Zetao @ 2022-07-01 9:40 UTC (permalink / raw)
To: Larry.Finger, phil, paskripkin, gregkh, huangzetao1
Cc: straube.linux, martin, abdun.nihaal, linux-staging, inux-kernel
Using eth_broadcast_addr() to assign broadcast address instead of memset().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Huang Zetao <huangzetao1@huawei.com>
---
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index 047e9c7d38c3..b9c0b7ee05f1 100644
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -1823,7 +1823,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev,
return -ENOMEM;
param->cmd = IEEE_CMD_SET_ENCRYPTION;
- memset(param->sta_addr, 0xff, ETH_ALEN);
+ eth_broadcast_addr(param->sta_addr);
switch (pext->alg) {
case IW_ENCODE_ALG_NONE:
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address
2022-07-01 9:40 [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address Huang Zetao
@ 2022-07-01 9:49 ` Greg KH
2022-07-04 2:45 ` 答复: " huangzetao
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2022-07-01 9:49 UTC (permalink / raw)
To: Huang Zetao
Cc: Larry.Finger, phil, paskripkin, straube.linux, martin,
abdun.nihaal, linux-staging, inux-kernel
On Fri, Jul 01, 2022 at 09:40:11AM +0000, Huang Zetao wrote:
> Using eth_broadcast_addr() to assign broadcast address instead of memset().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
Please follow the rules outlined in
Documentation/process/researcher-guidelines.rst when submitting patches
found by a random, private, unknown tool.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* 答复: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address
2022-07-01 9:49 ` Greg KH
@ 2022-07-04 2:45 ` huangzetao
2022-07-07 19:56 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: huangzetao @ 2022-07-04 2:45 UTC (permalink / raw)
To: Greg KH
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
abdun.nihaal@gmail.com, linux-staging@lists.linux.dev,
inux-kernel@vger.kernel.org
Please disregard it.
-----邮件原件-----
发件人: Greg KH <gregkh@linuxfoundation.org>
发送时间: 2022年7月1日 17:50
收件人: huangzetao <huangzetao1@huawei.com>
抄送: Larry.Finger@lwfinger.net; phil@philpotter.co.uk; paskripkin@gmail.com; straube.linux@gmail.com; martin@kaiser.cx; abdun.nihaal@gmail.com; linux-staging@lists.linux.dev; inux-kernel@vger.kernel.org
主题: Re: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address
On Fri, Jul 01, 2022 at 09:40:11AM +0000, Huang Zetao wrote:
> Using eth_broadcast_addr() to assign broadcast address instead of memset().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
Please follow the rules outlined in
Documentation/process/researcher-guidelines.rst when submitting patches found by a random, private, unknown tool.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 答复: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address
2022-07-04 2:45 ` 答复: " huangzetao
@ 2022-07-07 19:56 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2022-07-07 19:56 UTC (permalink / raw)
To: huangzetao
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
abdun.nihaal@gmail.com, linux-staging@lists.linux.dev,
inux-kernel@vger.kernel.org
On Mon, Jul 04, 2022 at 02:45:45AM +0000, huangzetao wrote:
> Please disregard it.
Ok, I will now disregard all patches with the "reported-by: Hulk Robot".
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-07 19:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-01 9:40 [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address Huang Zetao
2022-07-01 9:49 ` Greg KH
2022-07-04 2:45 ` 答复: " huangzetao
2022-07-07 19:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).