From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0029C7E6 for ; Mon, 20 Jun 2022 08:02:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 183D7C3411B; Mon, 20 Jun 2022 08:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655712128; bh=DwhU0/KxtnYlqxZj35So4aWeWj3iqMidFqPyuGEWOsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nCl1xAjYaSjiD2yiORDCzx4gxd/Q1ObwVxYAlnPd4KDTvk4uR3JvCEfiAaigmwOHh kboBiyjYZDBKr1ti6TSy02x09OWEoPtBDztSNmtdC+Lgu/+mCHlh7vdItt0U9X3ZCp 8ITi4zITqaFhkBANt3N8buI2jQoI1XKRnQEdr+KM= Date: Mon, 20 Jun 2022 10:02:05 +0200 From: Greg KH To: Souptick Joarder Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com, alexandre.belloni@bootlin.com, rafael@kernel.org, mathieu.poirier@linaro.org, u.kleine-koenig@pengutronix.de, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Kernel test robot Subject: Re: [PATCH] vme: Added NULL check for bridge Message-ID: References: <20220619070645.100947-1-jrdr.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220619070645.100947-1-jrdr.linux@gmail.com> On Sun, Jun 19, 2022 at 12:36:45PM +0530, Souptick Joarder wrote: > From: "Souptick Joarder (HPE)" > > Kernel test robot throws below warning -> > drivers/staging/vme_user/vme.c:662:20: warning: dereference > of NULL 'bridge' [CWE-476] [-Wanalyzer-null-dereference] > > Added a NULL check. > > Reported-by: Kernel test robot > Signed-off-by: Souptick Joarder (HPE) > --- > drivers/staging/vme_user/vme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c > index b5555683a069..ede774f2fe5a 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -659,7 +659,7 @@ ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t count, > struct vme_master_resource *image; > size_t length; > > - if (!bridge->master_read) { > + if (bridge && !bridge->master_read) { How can bridge ever be NULL here? thanks, greg k-h