From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20AF87A for ; Wed, 29 Jun 2022 19:14:47 +0000 (UTC) Received: by mail-ot1-f52.google.com with SMTP id t26-20020a9d775a000000b006168f7563daso12902168otl.2 for ; Wed, 29 Jun 2022 12:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eRvm4rDKmcEwBbyuwqdiLOYlQxia+jN6V897QRefdLU=; b=L4InWoTsn6Ktys0sawYAPemhPMW/VXMH5wMvdPN/pkmSDn9hNd7667tes6wDEswIyP APqL7zS9gB4bGUDGZJ4BTHZjwb24nmkF77U9ur/1eAmk3ka4AV6Akj8p7P8nayFiIQNj +fYNFjAl6TgVnSN0TFfMd6aNcukgKZHrtFZylwK9uTS+Swc1wkr56lRppUhpgv9yBlzz A03B+r2BtlQEzo9LQ3T/Gq9YDZvxTQ5+yGJkL9lmgueicuJvP2HO9PODecXYsmbsM63l GFfuHqyNm/3kmoJiyjrgupP6mhAWMJ760UTt0uVgaPcJSEPqbSTnn+4jk6hQcL74A1HM qVlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eRvm4rDKmcEwBbyuwqdiLOYlQxia+jN6V897QRefdLU=; b=RfNGT9baymV5qHeCvdwxGPovtj1RY5ylu6JOo2cdAEA/v63eI9a3gwes0oZH+ArY8s jnTVxV5Ghlnv623CDWZtwhG+JPit/jCtL/r2nZYkNFTtYzM69o3wz68lRe23dUvJt0qO c2kImUnNGG7q05CGsvKLG7W+sOmFT4Ocl40y6fxkLvAsd1vj2kAm6Z3cfbNlJDhcRmhF sP1ComRjmFKaHORQqPUzVbs3xuHGWniU6FicOYIxzZDR72mRseAZyCabXVML3z3PZPab TjB8iAhzSOg+GIv+lV+PelfwImNo0CjbLil4Q7ynqBWBiXwV5jXqMM7uTm6+CvbotkJ1 RKLQ== X-Gm-Message-State: AJIora/iVQTcPFc7DK9d013GyHQ5Nkc9LbgCnen1gwc4LomsTgVi/FBI 0ogO7HtNAnx23CcCq35jyDsK9w== X-Google-Smtp-Source: AGRyM1szpNbg71NbMlEOjlyo2a2vZG7dvYgtoZ+JqfGK1PvPW4R6BGZcZ87hUHjQLSpaX5EOLTHiCg== X-Received: by 2002:a9d:bf6:0:b0:616:d0fe:8b7b with SMTP id 109-20020a9d0bf6000000b00616d0fe8b7bmr2248941oth.19.1656530086223; Wed, 29 Jun 2022 12:14:46 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id z23-20020a544597000000b003342a70fd59sm8874989oib.10.2022.06.29.12.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 12:14:45 -0700 (PDT) Date: Wed, 29 Jun 2022 16:14:40 -0300 From: Ezequiel Garcia To: Jernej Skrabec Cc: p.zabel@pengutronix.de, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, benjamin.gaignard@collabora.com, nicolas.dufresne@collabora.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 5/7] media: hantro: postproc: Properly calculate chroma offset Message-ID: References: <20220616202513.351039-1-jernej.skrabec@gmail.com> <20220616202513.351039-6-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616202513.351039-6-jernej.skrabec@gmail.com> Hi Jernej, On Thu, Jun 16, 2022 at 10:25:11PM +0200, Jernej Skrabec wrote: > Currently chroma offset calculation assumes only 1 byte per luma, with > no consideration for stride. > > Take necessary information from destination pixel format which makes > calculation completely universal. > > Signed-off-by: Jernej Skrabec Reviewed-by: Ezequiel Garcia Thanks, Ezequiel > --- > drivers/staging/media/hantro/hantro_postproc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro_postproc.c b/drivers/staging/media/hantro/hantro_postproc.c > index 8933b4af73ed..a0928c508434 100644 > --- a/drivers/staging/media/hantro/hantro_postproc.c > +++ b/drivers/staging/media/hantro/hantro_postproc.c > @@ -113,12 +113,14 @@ static void hantro_postproc_g2_enable(struct hantro_ctx *ctx) > { > struct hantro_dev *vpu = ctx->dev; > struct vb2_v4l2_buffer *dst_buf; > - size_t chroma_offset = ctx->dst_fmt.width * ctx->dst_fmt.height; > int down_scale = down_scale_factor(ctx); > + size_t chroma_offset; > dma_addr_t dst_dma; > > dst_buf = hantro_get_dst_buf(ctx); > dst_dma = vb2_dma_contig_plane_dma_addr(&dst_buf->vb2_buf, 0); > + chroma_offset = ctx->dst_fmt.plane_fmt[0].bytesperline * > + ctx->dst_fmt.height; > > if (down_scale) { > hantro_reg_write(vpu, &g2_down_scale_e, 1); > -- > 2.36.1 >